Fix missing default features. Fix debug symbol stripping being applied to all modes instead of just fastbuild.

Author: calebzulawski

bazel/BUILD

@@ -5,5 +5,24 @@ portable_cc_toolchain(
     apple_os_versions = {
         "macos": "11",
     },
+    dbg_features = [
+        "//feature:asan",
+        "//feature:ubsan",
+        "//feature:lsan",
+        "//feature:no_optimization",  # in a future version, this could be debug_optimization
+    ],
+    enabled_features = [
+        "//feature:c17",
+        "//feature:cpp17",
+        "//feature:warnings_enabled",
+        "//feature:debug_symbols",
+        "//feature:strip_unused_dynamic_libs",
+    ],
+    fastbuild_features = [
+        "//feature:no_optimization",
+    ],
+    opt_features = [
+        "//feature:moderate_optimization",
+    ],
     visibility = ["//visibility:public"],
 )

bazel/feature/BUILD

@@ -4,7 +4,6 @@ load("doc.bzl", "generate_features_doc")
 
 FEATURES = [
     "//feature/misc:debug_symbols",
-    "//feature/misc:strip_debug_symbols",
     "//feature/misc:strip_unused_dynamic_libs",
     "//feature/misc:thinlto",
     "//feature/misc:coverage",

bazel/feature/README.md

@@ -3,7 +3,6 @@
 | Feature | Target | Description |
 | ------- | ------ | ----------- |
 | `debug_symbols` | `//feature:debug_symbols` | Generage debug information |
-| `strip_debug_symbols` | `//feature:strip_debug_symbols` | Strip debug information |
 | `strip_unused_dynamic_libs` | `//feature:strip_unused_dynamic_libs` | Don't link against dynamic libraries that aren't referenced by any symbols |
 | `thinlto` | `//feature:thinlto` | Link with ThinLTO (incremental link time optimization) |
 | `coverage` | `//feature:coverage` | Compile with instrumentation for code coverage |

bazel/feature/doc.bzl

@@ -2,7 +2,6 @@ load("//feature/std:standards.bzl", "STANDARDS_FEATURES")
 
 FEATURES = {
     "//feature:debug_symbols": "Generage debug information",
-    "//feature:strip_debug_symbols": "Strip debug information",
     "//feature:strip_unused_dynamic_libs": "Don't link against dynamic libraries that aren't referenced by any symbols",
     "//feature:thinlto": "Link with ThinLTO (incremental link time optimization)",
     "//feature:coverage": "Compile with instrumentation for code coverage",

bazel/feature/misc/BUILD

@@ -40,21 +40,6 @@ cc_args(
     args = ["-gmlt"],
 )
 
-# Strip debug symbols
-
-cc_feature(
-    name = "strip_debug_symbols",
-    args = ["strip_debug_symbols_args"],
-    overrides = "@rules_cc//cc/toolchains/features/legacy:strip_debug_symbols",
-    visibility = ["//feature:__pkg__"],
-)
-
-cc_args(
-    name = "strip_debug_symbols_args",
-    actions = ["@rules_cc//cc/toolchains/actions:link_actions"],
-    args = ["-Wl,-S"],
-)
-
 # Hide symbols
 
 cc_feature(

bazel/toolchain.bzl

@@ -2,30 +2,6 @@ load("@rules_cc//cc/toolchains:toolchain.bzl", "cc_toolchain")
 load("//detail/args:target.bzl", "target_args")
 load("//feature:doc.bzl", "FEATURES")
 
-DEFAULT_ENABLED_FEATURES = [
-    "//feature:c17",
-    "//feature:cpp17",
-    "//feature:warnings_enabled",
-    "//feature:debug_symbols",
-    "//feature:strip_unused_dynamic_libs",
-]
-
-DEFAULT_FASTBUILD_FEATURES = [
-    "//feature:strip_debug_symbols",
-    "//feature:no_optimization",
-]
-
-DEFAULT_DBG_FEATURES = [
-    "//feature:asan",
-    "//feature:ubsan",
-    "//feature:lsan",
-    "//feature:no_optimization",  # in a future version, this could be debug_optimization
-]
-
-DEFAULT_OPT_FEATURES = [
-    "//feature:moderate_optimization",
-]
-
 def portable_cc_toolchain(
         name,
         args = [],