Skip to content

Commit 6d02e11

Browse files
authored
Warning fixes (#121)
* disabled CA1416 as it should only run on windows * Fixed buildDate cannot be null warning * Fixed WFAC010 warning about the HighDPImode in manifest
1 parent 86294fb commit 6d02e11

File tree

3 files changed

+5
-13
lines changed

3 files changed

+5
-13
lines changed

EDSEditorGUI/EDSEditorGUI.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,17 @@
2525
<UseWindowsForms>true</UseWindowsForms>
2626
<ImportWindowsDesktopTargets>true</ImportWindowsDesktopTargets>
2727
<EmbeddedResourceUseDependentUponConvention>true</EmbeddedResourceUseDependentUponConvention>
28+
<ApplicationHighDpiMode>SystemAware</ApplicationHighDpiMode>
2829
</PropertyGroup>
2930
<PropertyGroup>
3031
<ApplicationIcon>Index_8287_16x.ico</ApplicationIcon>
3132
</PropertyGroup>
3233
<PropertyGroup>
3334
<ApplicationManifest>app.manifest</ApplicationManifest>
3435
</PropertyGroup>
36+
<PropertyGroup>
37+
<NoWarn>$(NoWarn);CA1416</NoWarn>
38+
</PropertyGroup>
3539
<ItemGroup>
3640
<Reference Include="Microsoft.mshtml, Version=7.0.3300.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a">
3741
<SpecificVersion>False</SpecificVersion>

EDSEditorGUI/app.manifest

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,6 @@
4545
</application>
4646
</compatibility>
4747

48-
<!-- Indicates that the application is DPI-aware and will not be automatically scaled by Windows at higher
49-
DPIs. Windows Presentation Foundation (WPF) applications are automatically DPI-aware and do not need
50-
to opt in. Windows Forms applications targeting .NET Framework 4.6 that opt into this setting, should
51-
also set the 'EnableWindowsFormsHighDpiAutoResizing' setting to 'true' in their app.config. -->
52-
53-
<application xmlns="urn:schemas-microsoft-com:asm.v3">
54-
<windowsSettings>
55-
<dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>
56-
</windowsSettings>
57-
</application>
58-
59-
6048
<!-- Enable themes for Windows common controls and dialogs (Windows XP and later) -->
6149
<!--
6250
<dependency>

libEDSsharp/CanOpenXDD.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -786,7 +786,7 @@ public EDSsharp convert(ISO15745ProfileContainer container)
786786
productID = ApplicationLayers.identity.productID.Value;
787787
}
788788

789-
if (ApplicationLayers.identity.buildDate != null)
789+
if (ApplicationLayers.identity.buildDate != default)
790790
{
791791
buildDate = ApplicationLayers.identity.buildDate;
792792
}

0 commit comments

Comments
 (0)