Fix buffer data deallocation in unload path / stack frame size compilation warning

Author: JohnMalliotakis

driver/mmap_banked_buffer.c

@@ -81,7 +81,6 @@ void cleanup_mmap_buffer_data_banked_buffer_t(banked_buffer_t *buf)
 
 	printk(KERN_INFO "Cleaning up data structures for the banked buffer\n");
 	cleanup_mmap_buffer_data(buf->banks);
-	kfree(buf->banks);
 	kfree(buf);
 }
 

driver/mmap_fault_handler.c

@@ -903,8 +903,6 @@ static void pve_release(struct kref *kref)
 	__pve_release(pve);
 }
 
-static void pve_empty(struct kref *kref){}
-
 void perma_vma_close(struct vm_area_struct *vma)
 {
 	//struct pr_vma_data *pvd;
@@ -933,11 +931,9 @@ void perma_vma_close(struct vm_area_struct *vma)
 	pve = ((struct fastmap_info *)vma->vm_private_data)->pve;
 	DMAP_BGON(pve == NULL);
 
-	pve_release(&pve->refcount);
-	if(kref_put(&pve->refcount, pve_empty) == 1){ // pve_release called!
-		// FIXME
-		// kmem_cache_free(pve_alloc_cache, pve);
-		// vma->is_fastmap = false;
+	if(kref_put(&pve->refcount, pve_release) == 1){ // pve_release called!
+		 kmem_cache_free(pve_alloc_cache, pve);
+		 ((struct fastmap_info *)vma->vm_private_data)->is_fastmap = false;
 	}
 
 	//atomic64_dec(&pvd->cnt);

driver/mmap_generational_fifo_buffer.c

@@ -612,7 +612,8 @@ unsigned int try_purge_pages_fast(fifo_buffer_t *buf, unsigned int N, int qid)
 	unsigned int radix_tree_id;
 #endif
 	//struct tagged_page **pgs = page_address(alloc_page(GFP_KERNEL));
-	struct tagged_page *pgs[192];
+	struct tagged_page **pgs = vmalloc(192 * sizeof(struct tagged_page *));
+	DMAP_BGON(pgs == NULL);
 
 	N = 192;
 
@@ -666,6 +667,7 @@ unsigned int try_purge_pages_fast(fifo_buffer_t *buf, unsigned int N, int qid)
 
 	//free_page((long unsigned int)pgs);
 
+	vfree(pgs);
 	return num_pgs;
 }
 
@@ -869,15 +871,18 @@ fifo_buffer_t *init_mmap_buffer_data_fifo_buffer_t(fifo_buffer_t *dummy, buf_ld_
 
 void cleanup_mmap_buffer_data_fifo_buffer_t(fifo_buffer_t *buf)
 {
+	int i;
 	buf->evictor_run = false;
 	while(atomic_read(&active_evictors) != 0)
 		ssleep(1);
 	ssleep(1); /* wait a bit more for everything to complete */
 
 	free_hash_table(&buf->page_map);
 
-	kfree(buf->primary_fifo_data);
-	kfree(buf->dirty_queue);
+	for(i=0; i < NUM_QUEUES; i++)
+		kfree(buf->primary_fifo_data[i]);
+	for(i=0; i < EVICTOR_THREADS; i++)
+		kfree(buf->dirty_queue[i]);
 	kfree(buf);
 }