Skip to content

Commit 6a49b55

Browse files
jedrazbleemthompo
authored andcommitted
[Agent Builder]: Nits around ES|QL search in index search tool type (elastic#235310)
## Summary - `documents` -> `results` - `ES|QL` -> `ES|QL query` Fix i18n usage <img width="948" height="775" alt="Screenshot 2025-09-17 at 10 00 06" src="https://github.com/user-attachments/assets/828f3422-6188-462a-b58b-480d317d912e" /> --------- Co-authored-by: Liam Thompson <[email protected]>
1 parent 4272ab7 commit 6a49b55

File tree

2 files changed

+28
-28
lines changed
  • x-pack/platform
    • packages/shared/onechat/onechat-genai-utils/tools/search
    • plugins/shared/onechat/public/application/components/conversations/conversation_rounds/round_thinking/steps

2 files changed

+28
-28
lines changed

x-pack/platform/packages/shared/onechat/onechat-genai-utils/tools/search/i18n.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const progressMessages = {
3636
},
3737
performingNlSearch: ({ query }: { query: string }) => {
3838
return i18n.translate('xpack.onechat.tools.search.progress.performingTextSearch', {
39-
defaultMessage: 'Generating an ES|QL for "{query}"',
39+
defaultMessage: 'Generating an ES|QL query for "{query}"',
4040
values: {
4141
query,
4242
},

x-pack/platform/plugins/shared/onechat/public/application/components/conversations/conversation_rounds/round_thinking/steps/tabular_data_result_step.tsx

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -40,34 +40,34 @@ export const TabularDataResultStep: React.FC<TabularDataResultStepProps> = ({
4040
return (
4141
<EuiFlexGroup direction="row" gutterSize="xs" alignItems="center">
4242
<EuiText size="s">
43-
{i18n.translate(
44-
'xpack.onechat.conversation.thinking.tabularDataResultStep.foundRecordsMessagePrefix',
45-
{
46-
defaultMessage: 'Found',
47-
}
48-
)}
43+
<FormattedMessage
44+
id="xpack.onechat.conversation.thinking.tabularDataResultStep.foundRecordsMessage"
45+
defaultMessage="Found {results}"
46+
values={{
47+
results: (
48+
<EuiLink
49+
href={discoverUrl}
50+
data-test-subj="onechat-esql-data-result-see-in-discover"
51+
aria-label={i18n.translate(
52+
'xpack.onechat.conversation.thinking.tabularDataResultStep.seeInDiscoverAriaLabel',
53+
{
54+
defaultMessage: 'Explore results in Discover',
55+
}
56+
)}
57+
target="_blank"
58+
>
59+
<FormattedMessage
60+
id="xpack.onechat.conversation.thinking.tabularDataResultStep.foundRecordsMessage"
61+
defaultMessage="{totalResults, plural, one {{totalResults, number} result} other {{totalResults, number} results}}"
62+
values={{
63+
totalResults: data.values.length,
64+
}}
65+
/>
66+
</EuiLink>
67+
),
68+
}}
69+
/>
4970
</EuiText>
50-
{discoverUrl && (
51-
<EuiLink
52-
href={discoverUrl}
53-
data-test-subj="onechat-esql-data-result-see-in-discover"
54-
aria-label={i18n.translate(
55-
'xpack.onechat.conversation.thinking.tabularDataResultStep.seeInDiscoverAriaLabel',
56-
{
57-
defaultMessage: 'See documents in Discover',
58-
}
59-
)}
60-
target="_blank"
61-
>
62-
<FormattedMessage
63-
id="xpack.onechat.conversation.thinking.tabularDataResultStep.foundRecordsMessage"
64-
defaultMessage="{totalDocuments, plural, one {{totalDocuments, number} document} other {{totalDocuments, number} documents}}"
65-
values={{
66-
totalDocuments: data.values.length,
67-
}}
68-
/>
69-
</EuiLink>
70-
)}
7171
</EuiFlexGroup>
7272
);
7373
};

0 commit comments

Comments
 (0)