Skip to content

Commit 7c4e25e

Browse files
dgieselaarelasticmachinekibanamachine
authored andcommitted
[Infra] Use callback for logger.trace calls (elastic#199805)
Use a callback for logger.trace() so big objects only get stringified when trace logging is enabled. --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>
1 parent 9674c54 commit 7c4e25e

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

x-pack/plugins/observability_solution/infra/server/lib/alerting/inventory_metric_threshold/lib/get_data.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,9 @@ export const getData = async (
159159
customMetric,
160160
fieldsExisted
161161
);
162-
logger.trace(`Request: ${JSON.stringify(request)}`);
162+
logger.trace(() => `Request: ${JSON.stringify(request)}`);
163163
const body = await esClient.search<undefined, ResponseAggregations>(request);
164-
logger.trace(`Response: ${JSON.stringify(body)}`);
164+
logger.trace(() => `Response: ${JSON.stringify(body)}`);
165165
if (body.aggregations) {
166166
return handleResponse(body.aggregations, previousNodes);
167167
}

x-pack/plugins/observability_solution/infra/server/lib/alerting/metric_threshold/lib/check_missing_group.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ export const checkMissingGroups = async (
5757
];
5858
});
5959

60-
logger.trace(`Request: ${JSON.stringify({ searches })}`);
60+
logger.trace(() => `Request: ${JSON.stringify({ searches })}`);
6161
const response = await esClient.msearch({ searches });
62-
logger.trace(`Response: ${JSON.stringify(response)}`);
62+
logger.trace(() => `Response: ${JSON.stringify(response)}`);
6363

6464
const verifiedMissingGroups = response.responses
6565
.map((resp, index) => {

x-pack/plugins/observability_solution/infra/server/lib/alerting/metric_threshold/lib/get_data.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,10 +277,10 @@ export const getData = async (
277277
fieldsExisted
278278
),
279279
};
280-
logger.trace(`Request: ${JSON.stringify(request)}`);
280+
logger.trace(() => `Request: ${JSON.stringify(request)}`);
281281
const body = await esClient.search<undefined, ResponseAggregations>(request);
282282
const { aggregations, _shards } = body;
283-
logger.trace(`Response: ${JSON.stringify(body)}`);
283+
logger.trace(() => `Response: ${JSON.stringify(body)}`);
284284
if (aggregations) {
285285
return handleResponse(aggregations, previousResults, _shards.successful);
286286
} else if (_shards.successful) {

0 commit comments

Comments
 (0)