Skip to content

Commit c7ce3b9

Browse files
mariairiartefCAWilson94
authored andcommitted
[Lens] [Metric chart] Update appearance popover (elastic#233992)
Closes elastic#233702 ## Summary Updates titles and text toolbar popover for metric chart, now called "Appearance". https://github.com/user-attachments/assets/54bcd8aa-cf87-45e2-a39c-3ec6fa8bf59e Shows all settings and disables the ones that weren't shown before: subtitle, secondary metric align and icon position. <img width="2560" height="906" alt="Screenshot 2025-09-04 at 13 41 46" src="https://github.com/user-attachments/assets/431e7e4a-6962-4de6-805e-8238ff6a72d4" /> #### Considerations Prevents unnecessary state updates by ensuring that when a user clicks an option that is already selected, the state is not updated. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
1 parent 59efbe2 commit c7ce3b9

File tree

14 files changed

+758
-943
lines changed

14 files changed

+758
-943
lines changed

x-pack/platform/plugins/private/translations/translations/de-DE.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24205,7 +24205,6 @@
2420524205
"xpack.lens.metric.progressDirection.vertical": "Vertikal",
2420624206
"xpack.lens.metric.progressDirectionLabel": "Bar-Ausrichtung",
2420724207
"xpack.lens.metric.secondaryMetric": "Sekundäre Metrik",
24208-
"xpack.lens.metric.subtitleLabel": "Untertitel",
2420924208
"xpack.lens.metric.summportingVis.needMaxDimension": "Für Balkenvisualisierungen muss ein Höchstwert festgelegt werden.",
2421024209
"xpack.lens.metric.supportingVis.label": "Unterstützung der Visualisierung",
2421124210
"xpack.lens.metric.supportingVis.metricHasReducedTimeRange": "Linienvisualisierungen können nicht verwendet werden, wenn ein reduzierter Zeitbereich auf die primäre Metrik angewendet wird.",
@@ -24215,14 +24214,6 @@
2421524214
"xpack.lens.metric.supportingVisualization.bar": "Leiste",
2421624215
"xpack.lens.metric.supportingVisualization.trendline": "Zeile",
2421724216
"xpack.lens.metric.timeField": "Zeitfeld",
24218-
"xpack.lens.metric.toolbarTitlesText.default": "Standardeinstellungen",
24219-
"xpack.lens.metric.toolbarTitlesText.fit": "Anpassen",
24220-
"xpack.lens.metric.toolbarTitlesText.iconAlignment": "Symbolausrichtung",
24221-
"xpack.lens.metric.toolbarTitlesText.label": "Titel und Text",
24222-
"xpack.lens.metric.toolbarTitlesText.titlesAlignment": "Titelausrichtung",
24223-
"xpack.lens.metric.toolbarTitlesText.titlesAlignmentTip": "Ausrichtung des Titels und Untertitels",
24224-
"xpack.lens.metric.toolbarTitlesText.valueFontSize": "Schriftgröße des Werts",
24225-
"xpack.lens.metric.toolbarTitlesText.valueFontSizeTip": "Schriftgröße des Primärmetrikwerts",
2422624217
"xpack.lens.metric.visualizationDescription": "Präsentieren Sie individuelle Schlüsselkennzahlen oder KPIs.",
2422724218
"xpack.lens.missingTimeRangeParam.longMessage": "Die Eigenschaft timeRange ist für die angegebene Konfiguration erforderlich",
2422824219
"xpack.lens.missingTimeRangeParam.shortMessage": "Fehlende timeRange-Eigenschaft",

x-pack/platform/plugins/private/translations/translations/fr-FR.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24272,7 +24272,6 @@
2427224272
"xpack.lens.metric.progressDirection.vertical": "Vertical",
2427324273
"xpack.lens.metric.progressDirectionLabel": "Orientation de la barre",
2427424274
"xpack.lens.metric.secondaryMetric": "Indicateur secondaire",
24275-
"xpack.lens.metric.subtitleLabel": "Sous-titre",
2427624275
"xpack.lens.metric.summportingVis.needMaxDimension": "Les visualisations des barres requièrent la définition d'une valeur maximale.",
2427724276
"xpack.lens.metric.supportingVis.label": "Visualisation de support",
2427824277
"xpack.lens.metric.supportingVis.metricHasReducedTimeRange": "Les visualisations linéaires ne peuvent pas être utilisées lorsqu'une plage temporelle réduite est appliquée à l'indicateur principal.",
@@ -24282,14 +24281,6 @@
2428224281
"xpack.lens.metric.supportingVisualization.bar": "Barres",
2428324282
"xpack.lens.metric.supportingVisualization.trendline": "Ligne",
2428424283
"xpack.lens.metric.timeField": "Champ temporel",
24285-
"xpack.lens.metric.toolbarTitlesText.default": "Par défaut",
24286-
"xpack.lens.metric.toolbarTitlesText.fit": "Ajuster",
24287-
"xpack.lens.metric.toolbarTitlesText.iconAlignment": "Alignement des icônes",
24288-
"xpack.lens.metric.toolbarTitlesText.label": "Titres et texte",
24289-
"xpack.lens.metric.toolbarTitlesText.titlesAlignment": "Alignement des titres",
24290-
"xpack.lens.metric.toolbarTitlesText.titlesAlignmentTip": "Alignement du titre et du sous-titre",
24291-
"xpack.lens.metric.toolbarTitlesText.valueFontSize": "Taille de police de la valeur",
24292-
"xpack.lens.metric.toolbarTitlesText.valueFontSizeTip": "Taille de police de la valeur d'indicateur principal",
2429324284
"xpack.lens.metric.visualizationDescription": "Présentez les indicateurs clés de performance individuels.",
2429424285
"xpack.lens.missingTimeRangeParam.longMessage": "La propriété timeRange est requise pour cette configuration.",
2429524286
"xpack.lens.missingTimeRangeParam.shortMessage": "Propriété timeRange manquante",

x-pack/platform/plugins/private/translations/translations/ja-JP.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24303,7 +24303,6 @@
2430324303
"xpack.lens.metric.progressDirection.vertical": "縦",
2430424304
"xpack.lens.metric.progressDirectionLabel": "棒の向き",
2430524305
"xpack.lens.metric.secondaryMetric": "副メトリック",
24306-
"xpack.lens.metric.subtitleLabel": "サブタイトル",
2430724306
"xpack.lens.metric.summportingVis.needMaxDimension": "棒グラフの可視化では、最大値を定義する必要があります。",
2430824307
"xpack.lens.metric.supportingVis.label": "可視化のサポート",
2430924308
"xpack.lens.metric.supportingVis.metricHasReducedTimeRange": "縮小された時間範囲が主メトリックに適用されている場合は、折れ線グラフの可視化を使用できません。",
@@ -24313,14 +24312,6 @@
2431324312
"xpack.lens.metric.supportingVisualization.bar": "棒",
2431424313
"xpack.lens.metric.supportingVisualization.trendline": "折れ線",
2431524314
"xpack.lens.metric.timeField": "時間フィールド",
24316-
"xpack.lens.metric.toolbarTitlesText.default": "デフォルト",
24317-
"xpack.lens.metric.toolbarTitlesText.fit": "合わせる",
24318-
"xpack.lens.metric.toolbarTitlesText.iconAlignment": "アイコン配置",
24319-
"xpack.lens.metric.toolbarTitlesText.label": "タイトルとテキスト",
24320-
"xpack.lens.metric.toolbarTitlesText.titlesAlignment": "タイトル配置",
24321-
"xpack.lens.metric.toolbarTitlesText.titlesAlignmentTip": "タイトルとサブタイトルの配置",
24322-
"xpack.lens.metric.toolbarTitlesText.valueFontSize": "値フォントサイズ",
24323-
"xpack.lens.metric.toolbarTitlesText.valueFontSizeTip": "主メトリック値のフォントサイズ",
2432424315
"xpack.lens.metric.visualizationDescription": "個別の主要メトリックまたはKPIを提供します。",
2432524316
"xpack.lens.missingTimeRangeParam.longMessage": "指定された構成にはtimeRangeプロパティが必須です",
2432624317
"xpack.lens.missingTimeRangeParam.shortMessage": "timeRangeプロパティがありません",

x-pack/platform/plugins/private/translations/translations/zh-CN.json

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24295,7 +24295,6 @@
2429524295
"xpack.lens.metric.progressDirection.vertical": "垂直",
2429624296
"xpack.lens.metric.progressDirectionLabel": "条形图方向",
2429724297
"xpack.lens.metric.secondaryMetric": "次级指标",
24298-
"xpack.lens.metric.subtitleLabel": "子标题",
2429924298
"xpack.lens.metric.summportingVis.needMaxDimension": "条形图可视化需要定义一个最大值。",
2430024299
"xpack.lens.metric.supportingVis.label": "支持可视化",
2430124300
"xpack.lens.metric.supportingVis.metricHasReducedTimeRange": "将缩小的时间范围应用于主要指标时,无法使用折线图可视化。",
@@ -24305,14 +24304,6 @@
2430524304
"xpack.lens.metric.supportingVisualization.bar": "条形图",
2430624305
"xpack.lens.metric.supportingVisualization.trendline": "折线图",
2430724306
"xpack.lens.metric.timeField": "时间字段",
24308-
"xpack.lens.metric.toolbarTitlesText.default": "默认",
24309-
"xpack.lens.metric.toolbarTitlesText.fit": "适应",
24310-
"xpack.lens.metric.toolbarTitlesText.iconAlignment": "图标对齐方式",
24311-
"xpack.lens.metric.toolbarTitlesText.label": "标题和文本",
24312-
"xpack.lens.metric.toolbarTitlesText.titlesAlignment": "标题对齐方式",
24313-
"xpack.lens.metric.toolbarTitlesText.titlesAlignmentTip": "标题和子标题的对齐方式",
24314-
"xpack.lens.metric.toolbarTitlesText.valueFontSize": "值字体大小",
24315-
"xpack.lens.metric.toolbarTitlesText.valueFontSizeTip": "主要指标值的字体大小",
2431624307
"xpack.lens.metric.visualizationDescription": "展示单个关键指标或 KPI。",
2431724308
"xpack.lens.missingTimeRangeParam.longMessage": "给定配置需要包含 timeRange 属性",
2431824309
"xpack.lens.missingTimeRangeParam.shortMessage": "缺少 timeRange 属性",

x-pack/platform/plugins/shared/lens/public/shared_components/toolbar_popover.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export type ToolbarPopoverProps = Partial<EuiPopoverProps> & {
4343
handleClose?: () => void;
4444
};
4545

46-
const defaultPanelStyles = { width: '410px' };
46+
const defaultPanelStyles = { width: '420px' };
4747

4848
export const ToolbarPopover: React.FC<PropsWithChildren<ToolbarPopoverProps>> = ({
4949
children,
@@ -86,7 +86,7 @@ export const ToolbarPopover: React.FC<PropsWithChildren<ToolbarPopoverProps>> =
8686
handleClose?.();
8787
}}
8888
anchorPosition="downRight"
89-
panelPaddingSize="s"
89+
panelPaddingSize="m"
9090
{...euiPopoverProps}
9191
>
9292
<EuiPopoverTitle data-test-subj={`${euiPopoverProps['data-test-subj']}_title`}>

0 commit comments

Comments
 (0)