[Lens as Code] metric chart schema and transformations (elastic#233813)

## Summary

resolves elastic#233657 
resolves elastic#233659

---------

Co-authored-by: Marco Liberati <[email protected]>
Co-authored-by: kibanamachine <[email protected]>

Author: 3 people

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/config_builder.ts

@@ -20,8 +20,8 @@ import {
   buildTable,
   buildXY,
   buildPartitionChart,
-  fromMetricLegacyToAPI,
 } from './charts';
+import { fromAPItoLensState, fromLensStateToAPI } from './transforms/charts/metric';
 import type { LensApiState } from './schema';
 import { isLensLegacyFormat } from './utils';
 
@@ -43,13 +43,13 @@ export class LensConfigBuilder {
   };
 
   private apiConvertersByChart = {
-    metric: fromMetricLegacyToAPI,
+    metric: { fromAPItoLensState, fromLensStateToAPI },
   };
   private formulaAPI: FormulaPublicApi | undefined;
-  private dataViewsAPI: DataViewsCommon;
+  private dataViewsAPI: DataViewsCommon | undefined;
 
   // formulaApi is optional, as it is not necessary to use it when creating charts with ES|QL
-  constructor(dataViewsAPI: DataViewsCommon, formulaAPI?: FormulaPublicApi) {
+  constructor(dataViewsAPI?: DataViewsCommon, formulaAPI?: FormulaPublicApi) {
     this.formulaAPI = formulaAPI;
     this.dataViewsAPI = dataViewsAPI;
   }
@@ -64,6 +64,10 @@ export class LensConfigBuilder {
     config: LensConfig | LensApiState,
     options: LensConfigOptions = {}
   ): Promise<LensAttributes | LensEmbeddableInput> {
+    if (!this.dataViewsAPI) {
+      throw new Error('DataViews API is required to build Lens configurations');
+    }
+
     const chartType = isLensLegacyFormat(config) ? config.chartType : config.type;
     const chartBuilderFn = this.charts[chartType];
     const chartConfig = await chartBuilderFn(config as any, {
@@ -92,14 +96,21 @@ export class LensConfigBuilder {
     return chartState as LensAttributes;
   }
 
-  async toAPIFormat(config: LensAttributes): Promise<LensApiState> {
-    const chartType = config.visualizationType;
+  fromAPIFormat(config: LensApiState): LensAttributes {
+    // Currently we only support metric conversion from API to attributes
+    const chartType = config.type;
     if (chartType === 'metric') {
       const converter = this.apiConvertersByChart[chartType];
-      return converter(config, {
-        formulaAPI: this.formulaAPI,
-        dataViewsAPI: this.dataViewsAPI,
-      });
+      return converter.fromAPItoLensState(config);
+    }
+    throw new Error(`No attributes converter found for chart type: ${chartType}`);
+  }
+
+  toAPIFormat(config: LensAttributes): LensApiState {
+    const chartType = config.visualizationType;
+    if (chartType === 'lnsMetric') {
+      const converter = this.apiConvertersByChart.metric;
+      return converter.fromLensStateToAPI(config);
     }
     throw new Error(`No API converter found for chart type: ${chartType}`);
   }

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/metric.test.ts

@@ -331,6 +331,7 @@ describe('Metric Schema', () => {
           query: 'FROM my-index | LIMIT 100',
         },
         metric: {
+          operation: 'value',
           column: 'unique_count' as const,
           fit: false,
           alignments: { labels: 'left', value: 'left' },

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/metric.ts

@@ -25,6 +25,7 @@ import {
   uniqueCountMetricOperationSchema,
   sumMetricOperationSchema,
   esqlColumnSchema,
+  genericOperationOptionsSchema,
 } from '../metric_ops';
 import { coloringTypeSchema } from '../color';
 import { datasetSchema, datasetEsqlTableSchema } from '../dataset';
@@ -250,12 +251,20 @@ const esqlMetricState = schema.object({
   /**
    * Primary value configuration, must define operation.
    */
-  metric: schema.allOf([metricStatePrimaryMetricOptionsSchema, esqlColumnSchema]),
+  metric: schema.allOf([
+    schema.object(genericOperationOptionsSchema),
+    metricStatePrimaryMetricOptionsSchema,
+    esqlColumnSchema,
+  ]),
   /**
    * Secondary value configuration, must define operation.
    */
   secondary_metric: schema.maybe(
-    schema.allOf([metricStateSecondaryMetricOptionsSchema, esqlColumnSchema])
+    schema.allOf([
+      schema.object(genericOperationOptionsSchema),
+      metricStateSecondaryMetricOptionsSchema,
+      esqlColumnSchema,
+    ])
   ),
   /**
    * Configure how to break down the metric (e.g. show one metric per term).
@@ -266,3 +275,5 @@ const esqlMetricState = schema.object({
 export const metricStateSchema = schema.oneOf([metricStateSchemaNoESQL, esqlMetricState]);
 
 export type MetricState = TypeOf<typeof metricStateSchema>;
+export type MetricStateNoESQL = TypeOf<typeof metricStateSchemaNoESQL>;
+export type MetricStateESQL = TypeOf<typeof esqlMetricState>;

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/dataset.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { schema } from '@kbn/config-schema';
+import { schema, type TypeOf } from '@kbn/config-schema';
 
 export const datasetTypeSchema = schema.oneOf([
   // DataView dataset type
@@ -134,3 +134,6 @@ export const datasetEsqlTableTypeSchema = schema.oneOf([
 export const datasetEsqlTableSchema = {
   dataset: datasetEsqlTableTypeSchema,
 };
+
+const anyDatasetSchema = schema.oneOf([datasetTypeSchema, datasetEsqlTableTypeSchema]);
+export type DatasetType = TypeOf<typeof anyDatasetSchema>;

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/index.ts

@@ -16,7 +16,7 @@ export const lensApiStateSchema = schema.oneOf([metricStateSchema]);
 
 export type LensApiState = typeof lensApiStateSchema.type;
 
-export type { MetricState } from './charts/metric';
+export type { MetricState, metricStateSchemaNoESQL } from './charts/metric';
 
 export type NarrowByType<T, U> = T extends { type: U } ? T : never;
 

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/metric_ops.test.ts

@@ -35,6 +35,7 @@ describe('Metric Operations Schemas', () => {
   describe('columnValueOperationSchema', () => {
     it('validates a valid metric operation configuration', () => {
       const input = {
+        operation: 'value',
         column: 'sum' as const,
       };
 

src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/metric_ops.ts

@@ -19,7 +19,7 @@ import {
 } from './constants';
 import { LENS_EMPTY_AS_NULL_DEFAULT_VALUE } from '../transforms/columns/utils';
 
-const genericOperationOptionsSchema = {
+export const genericOperationOptionsSchema = {
   ...formatSchema,
   /**
    * Label for the operation
@@ -64,6 +64,7 @@ export const esqlColumnSchema = schema.object({
   /**
    * Value
    */
+  operation: schema.literal('value'),
   column: schema.string({
     meta: {
       description: 'Column to use',