Skip to content

Commit 595ab1f

Browse files
committed
fix some text overflow issue and widget testing.
1 parent 8d2a234 commit 595ab1f

File tree

3 files changed

+16
-13
lines changed

3 files changed

+16
-13
lines changed

lib/Pages/home_screen/widgets/add_torrent_file.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ class _AddAutoTorrentState extends State<AddAutoTorrent> {
8484
Padding(
8585
padding: const EdgeInsets.only(left: 5),
8686
child: Text(
87-
fileSelectedName.length > 25
88-
? fileSelectedName.substring(0, 25) +
87+
fileSelectedName.length > 24
88+
? fileSelectedName.substring(0, 24) +
8989
'.torrent'
9090
: fileSelectedName + '.torrent',
9191
style: TextStyle(

lib/Pages/home_screen/widgets/rss_feed_home_page.dart

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1464,6 +1464,9 @@ class _RSSFeedHomePageState extends State<RSSFeedHomePage>
14641464
physics: ClampingScrollPhysics(),
14651465
itemCount: state.rssRulesList.length,
14661466
itemBuilder: (context, index) {
1467+
String tagLable = "${l10n.feeds_tags}: " +
1468+
state.rssRulesList[index].tags[0]
1469+
.toString();
14671470
return Column(
14681471
children: [
14691472
ListTile(
@@ -1518,12 +1521,12 @@ class _RSSFeedHomePageState extends State<RSSFeedHomePage>
15181521
const EdgeInsets.all(
15191522
5.0),
15201523
child: Text(
1521-
"${l10n.feeds_tags}: " +
1522-
state
1523-
.rssRulesList[
1524-
index]
1525-
.tags[0]
1526-
.toString(),
1524+
tagLable.length <= 20
1525+
? tagLable
1526+
: tagLable
1527+
.substring(
1528+
0, 20) +
1529+
"..",
15271530
style: TextStyle(
15281531
fontSize: 12),
15291532
),

test/widget_test/settings_screen_widget_test.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -357,12 +357,12 @@ void main() {
357357
findsOneWidget);
358358
expect(find.byKey(Key('Select Language Dropdown')), findsOneWidget);
359359
expect(find.text('Language'), findsOneWidget);
360-
expect(find.text('English'), findsOneWidget);
361-
await tester.tap(find.text('English'));
360+
expect(find.text('Automatic'), findsOneWidget);
361+
await tester.tap(find.text('Automatic'));
362362
await tester.pumpAndSettle();
363-
expect(find.text('English'), findsNWidgets(2));
364-
expect(find.text('हिन्दी'), findsNWidgets(2));
365-
await tester.tap(find.text('हिन्दी').last);
363+
expect(find.text('English'), findsOneWidget);
364+
expect(find.text('हिन्दी'), findsOneWidget);
365+
await tester.tap(find.text('हिन्दी'));
366366
await tester.pumpAndSettle();
367367
expect(find.text('हिन्दी'), findsOneWidget);
368368
expect(find.widgetWithText(ElevatedButton, 'Set'), findsOneWidget);

0 commit comments

Comments
 (0)