Fix rsmpeg multiple version compilation issue

- Removed feature-based rsmpeg selection that was causing all versions to compile
- Now using simple platform-specific dependencies in Cargo.toml
- Only the platform-appropriate rsmpeg version will be downloaded and compiled
- Linux: rsmpeg 0.14.2 (FFmpeg 6)
- Windows: rsmpeg 0.17.0 (FFmpeg 7)
- macOS: rsmpeg 0.18.0 (FFmpeg 8)
- Simplified rsmpeg_compat module to just re-export rsmpeg
- Removed unnecessary feature flags and complexity

Author: prateekmedia

src/rust/Cargo.toml

@@ -26,11 +26,19 @@ lib_ccxr = { path = "lib_ccxr" }
 url = "2.5.4"
 encoding_rs = "0.8.5"
 
-# FFmpeg version-specific rsmpeg dependencies
-# Use feature flags to select: --features ffmpeg6, ffmpeg7, or ffmpeg8 (default)
-rsmpeg_ffmpeg6 = { package = "rsmpeg", version = "=0.14.2", default-features = false, features = ["link_system_ffmpeg"], optional = true }
-rsmpeg_ffmpeg7 = { package = "rsmpeg", version = "=0.17.0", default-features = false, features = ["link_system_ffmpeg"], optional = true }
-rsmpeg_ffmpeg8 = { package = "rsmpeg", version = "=0.18.0", default-features = false, features = ["link_system_ffmpeg"], optional = true }
+# Platform-specific rsmpeg versions
+[target.'cfg(target_os = "linux")'.dependencies]
+rsmpeg = { version = "=0.14.2", default-features = false, features = ["link_system_ffmpeg"], optional = true }
+
+[target.'cfg(target_os = "windows")'.dependencies]
+rsmpeg = { version = "=0.17.0", default-features = false, features = ["link_system_ffmpeg"], optional = true }
+
+[target.'cfg(target_os = "macos")'.dependencies]
+rsmpeg = { version = "=0.18.0", default-features = false, features = ["link_system_ffmpeg"], optional = true }
+
+# Fallback for other platforms (FreeBSD, etc.)
+[target.'cfg(not(any(target_os = "linux", target_os = "windows", target_os = "macos")))'.dependencies]
+rsmpeg = { version = "=0.18.0", default-features = false, features = ["link_system_ffmpeg"], optional = true }
 
 [build-dependencies]
 bindgen = "0.64.0"
@@ -41,14 +49,8 @@ wtv_debug = []
 enable_ffmpeg = []
 with_libcurl = []
 
-# FFmpeg version selection features (for manual override)
-ffmpeg6 = ["rsmpeg_ffmpeg6"]
-ffmpeg7 = ["rsmpeg_ffmpeg7"]
-ffmpeg8 = ["rsmpeg_ffmpeg8"]
-
-# hardsubx_ocr includes all FFmpeg versions, platform defaults: Linux=6, Windows=7, macOS/others=8
-# Override with --features "hardsubx_ocr,ffmpeg8" to force a specific version
-hardsubx_ocr = ["rsmpeg_ffmpeg6", "rsmpeg_ffmpeg7", "rsmpeg_ffmpeg8", "tesseract-sys", "leptonica-sys"]
+# hardsubx_ocr enables OCR and the platform-appropriate rsmpeg
+hardsubx_ocr = ["rsmpeg", "tesseract-sys", "leptonica-sys"]
 
 [profile.release-with-debug]
 inherits = "release"

src/rust/src/lib.rs

@@ -20,7 +20,7 @@ pub mod decoder;
 pub mod encoder;
 pub mod es;
 
-#[cfg(any(feature = "ffmpeg6", feature = "ffmpeg7", feature = "ffmpeg8"))]
+#[cfg(feature = "hardsubx_ocr")]
 pub mod rsmpeg_compat;
 
 #[cfg(feature = "hardsubx_ocr")]

src/rust/src/rsmpeg_compat.rs

@@ -1,40 +1,6 @@
-// Re-export rsmpeg based on selected FFmpeg version feature or platform defaults
+// Re-export rsmpeg - the version is determined by platform-specific dependencies in Cargo.toml
+// Linux: rsmpeg 0.14.2 (FFmpeg 6)
+// Windows: rsmpeg 0.17.0 (FFmpeg 7)
+// macOS/others: rsmpeg 0.18.0 (FFmpeg 8)
 
-// Explicit feature flags take precedence
-#[cfg(feature = "ffmpeg6")]
-pub use rsmpeg_ffmpeg6 as rsmpeg;
-
-#[cfg(all(feature = "ffmpeg7", not(feature = "ffmpeg6")))]
-pub use rsmpeg_ffmpeg7 as rsmpeg;
-
-#[cfg(all(feature = "ffmpeg8", not(feature = "ffmpeg6"), not(feature = "ffmpeg7")))]
-pub use rsmpeg_ffmpeg8 as rsmpeg;
-
-// Platform-specific defaults when no explicit feature is selected
-// Linux defaults to FFmpeg 6
-#[cfg(all(
-    target_os = "linux",
-    not(feature = "ffmpeg6"),
-    not(feature = "ffmpeg7"),
-    not(feature = "ffmpeg8")
-))]
-pub use rsmpeg_ffmpeg6 as rsmpeg;
-
-// Windows defaults to FFmpeg 7
-#[cfg(all(
-    target_os = "windows",
-    not(feature = "ffmpeg6"),
-    not(feature = "ffmpeg7"),
-    not(feature = "ffmpeg8")
-))]
-pub use rsmpeg_ffmpeg7 as rsmpeg;
-
-// macOS and other platforms default to FFmpeg 8
-#[cfg(all(
-    not(target_os = "linux"),
-    not(target_os = "windows"),
-    not(feature = "ffmpeg6"),
-    not(feature = "ffmpeg7"),
-    not(feature = "ffmpeg8")
-))]
-pub use rsmpeg_ffmpeg8 as rsmpeg;
+pub use rsmpeg;