Add platform-specific FFmpeg defaults

- Linux automatically uses FFmpeg 6 (no env var needed)
- Windows automatically uses FFmpeg 7 (no env var needed)
- macOS and others automatically use FFmpeg 8
- Removed FFMPEG_VERSION from CI workflows - no longer needed
- Platform defaults work automatically, but can still override with feature flags
- Build scripts still support FFMPEG_VERSION env var for manual override

Author: prateekmedia

.github/workflows/build_linux.yml

@@ -29,10 +29,7 @@ jobs:
       run: sudo apt update && sudo apt-get install libgpac-dev libtesseract-dev libavcodec-dev libavdevice-dev libx11-dev libxcb1-dev libxcb-shm0-dev
     - uses: actions/checkout@v4
     - name: build
-      run: |
-        # Use FFmpeg 6 for Linux CI
-        export FFMPEG_VERSION=ffmpeg6
-        ./build -hardsubx
+      run: ./build -hardsubx
       working-directory: ./linux
     - name: Display version information
       run: ./ccextractor --version

.github/workflows/build_windows.yml

@@ -116,7 +116,6 @@ jobs:
           CARGO_TARGET_DIR: "..\\..\\windows"
           BINDGEN_EXTRA_CLANG_ARGS: -fmsc-version=0
           VCPKG_ROOT: ${{ github.workspace }}/vcpkg
-          FFMPEG_VERSION: ffmpeg7
         run: msbuild ccextractor.sln /p:Configuration=Debug-Full /p:Platform=x64
         working-directory: ./windows
       - name: Display version information

src/rust/Cargo.toml

@@ -46,9 +46,9 @@ ffmpeg6 = ["rsmpeg_ffmpeg6"]
 ffmpeg7 = ["rsmpeg_ffmpeg7"]
 ffmpeg8 = ["rsmpeg_ffmpeg8"]
 
-# hardsubx_ocr defaults to FFmpeg 8, override with --features "hardsubx_ocr,ffmpeg6" or "hardsubx_ocr,ffmpeg7"
-# CI workflows should specify: Linux uses ffmpeg6, Windows uses ffmpeg7, macOS uses ffmpeg8
-hardsubx_ocr = ["rsmpeg_ffmpeg8", "tesseract-sys", "leptonica-sys"]
+# hardsubx_ocr includes all FFmpeg versions, platform defaults: Linux=6, Windows=7, macOS/others=8
+# Override with --features "hardsubx_ocr,ffmpeg8" to force a specific version
+hardsubx_ocr = ["rsmpeg_ffmpeg6", "rsmpeg_ffmpeg7", "rsmpeg_ffmpeg8", "tesseract-sys", "leptonica-sys"]
 
 [profile.release-with-debug]
 inherits = "release"

src/rust/src/rsmpeg_compat.rs

@@ -1,14 +1,40 @@
-// Re-export rsmpeg based on selected FFmpeg version feature
+// Re-export rsmpeg based on selected FFmpeg version feature or platform defaults
 
+// Explicit feature flags take precedence
 #[cfg(feature = "ffmpeg6")]
 pub use rsmpeg_ffmpeg6 as rsmpeg;
 
-#[cfg(feature = "ffmpeg7")]
+#[cfg(all(feature = "ffmpeg7", not(feature = "ffmpeg6")))]
 pub use rsmpeg_ffmpeg7 as rsmpeg;
 
-#[cfg(feature = "ffmpeg8")]
+#[cfg(all(feature = "ffmpeg8", not(feature = "ffmpeg6"), not(feature = "ffmpeg7")))]
 pub use rsmpeg_ffmpeg8 as rsmpeg;
 
-// Default to ffmpeg8 if no specific version is selected
-#[cfg(not(any(feature = "ffmpeg6", feature = "ffmpeg7", feature = "ffmpeg8")))]
+// Platform-specific defaults when no explicit feature is selected
+// Linux defaults to FFmpeg 6
+#[cfg(all(
+    target_os = "linux",
+    not(feature = "ffmpeg6"),
+    not(feature = "ffmpeg7"),
+    not(feature = "ffmpeg8")
+))]
+pub use rsmpeg_ffmpeg6 as rsmpeg;
+
+// Windows defaults to FFmpeg 7
+#[cfg(all(
+    target_os = "windows",
+    not(feature = "ffmpeg6"),
+    not(feature = "ffmpeg7"),
+    not(feature = "ffmpeg8")
+))]
+pub use rsmpeg_ffmpeg7 as rsmpeg;
+
+// macOS and other platforms default to FFmpeg 8
+#[cfg(all(
+    not(target_os = "linux"),
+    not(target_os = "windows"),
+    not(feature = "ffmpeg6"),
+    not(feature = "ffmpeg7"),
+    not(feature = "ffmpeg8")
+))]
 pub use rsmpeg_ffmpeg8 as rsmpeg;