fix: replace iconv with encoding_rs

Author: hrideshmg

src/rust/Cargo.lock

@@ -13,7 +13,6 @@ crate-type = ["staticlib"]
 [dependencies]
 log = "0.4.26"
 env_logger = "0.8.4"
-iconv = "0.1.1"
 palette = "0.6.1"
 rsmpeg = { version = "0.14.2", optional = true, features = [
     "link_system_ffmpeg",
@@ -28,6 +27,7 @@ cfg-if = "1.0.0"
 num-integer = "0.1.46"
 lib_ccxr = { path = "lib_ccxr" }
 url = "2.5.4"
+encoding_rs = "0.8.5"
 
 [build-dependencies]
 bindgen = "0.64.0"

src/rust/Cargo.toml

@@ -17,6 +17,7 @@ use crate::{
     bindings::*,
     utils::{is_false, is_true},
 };
+use encoding_rs::Encoding;
 
 use log::{debug, warn};
 
@@ -232,8 +233,17 @@ impl dtvcc_tv_screen {
                 };
                 debug!("Charset: {}", charset);
 
-                let op = iconv::decode(&buf, charset).map_err(|err| err.to_string())?;
-                writer.write_to_file(op.as_bytes())?;
+                // Look up the encoding by label (name)
+                if let Some(encoding) = Encoding::for_label(charset.as_bytes()) {
+                    let (cow, _encoding_used, had_errors) = encoding.decode(&buf);
+                    if had_errors {
+                        println!("Warning: Had errors during encoding from {charset} to UTF-8");
+                    }
+                    if _encoding_used != encoding {
+                        println!("Warning: Encoding specified ({}) does not match encoding detected ({})",charset,_encoding_used.name());
+                    }
+                    writer.write_to_file(cow.as_bytes())?;
+                }
             }
         } else {
             writer.write_to_file(&buf)?;