Merge pull request #1924 from Harshdhall01/cleanup-vcl-hrd-todo

cfsmp3 · web-flow · commit b5fc3e63c4c5 · 2025-12-30T08:49:18.000+01:00
Looks good! The explanation is clearer and removing the dead code (commented exit) is a nice cleanup. Tests pass.

Merging - thanks!
diff --git a/src/lib_ccx/avc_functions.c b/src/lib_ccx/avc_functions.c
@@ -903,10 +903,10 @@ void seq_parameter_set_rbsp(struct avc_ctx *ctx, unsigned char *seqbuf, unsigned
 		dvprint("vcl_hrd_parameters_present_flag=               %llX\n", tmp1);
 		if (tmp)
 		{
-			// TODO.
-			mprint("vcl_hrd. Not implemented for now. Hopefully not needed. Skipping rest of NAL\n");
+			// VCL HRD parameters are for video buffering compliance, not needed for caption extraction.
+			// Just skip and continue - this doesn't affect our ability to extract captions.
+			mprint("Skipping VCL HRD parameters (not needed for caption extraction)\n");
 			ctx->num_vcl_hrd++;
-			// exit(1);
 		}
 		if (tmp || tmp1)
 		{

Original file line number	Diff line number	Diff line change
`@@ -903,10 +903,10 @@ void seq_parameter_set_rbsp(struct avc_ctx ctx, unsigned char seqbuf, unsigned`
`903`	`903`	`dvprint("vcl_hrd_parameters_present_flag= %llX\n", tmp1);`
`904`	`904`	`if (tmp)`
`905`	`905`	`{`
`906`		`- // TODO.`
`907`		`- mprint("vcl_hrd. Not implemented for now. Hopefully not needed. Skipping rest of NAL\n");`
	`906`	`+ // VCL HRD parameters are for video buffering compliance, not needed for caption extraction.`
	`907`	`+ // Just skip and continue - this doesn't affect our ability to extract captions.`
	`908`	`+ mprint("Skipping VCL HRD parameters (not needed for caption extraction)\n");`
`908`	`909`	`ctx->num_vcl_hrd++;`
`909`		`- // exit(1);`
`910`	`910`	`}`
`911`	`911`	`if (tmp \|\| tmp1)`
`912`	`912`	`{`