Use target-specific rsmpeg configurations for FFmpeg compatibility

- Configure rsmpeg to use FFmpeg 6 on Linux, FFmpeg 7 on Windows, FFmpeg 8 on macOS
- Remove manual CI workflow modifications for FFmpeg compatibility
- Simplify CI configuration by leveraging Cargo's target-specific dependencies

Author: prateekmedia

.github/workflows/build_linux.yml

@@ -28,9 +28,6 @@ jobs:
     - name: Install dependencies
       run: sudo apt update && sudo apt-get install libgpac-dev libtesseract-dev libavcodec-dev libavdevice-dev libx11-dev libxcb1-dev libxcb-shm0-dev
     - uses: actions/checkout@v4
-    - name: Downgrade rsmpeg for FFmpeg 6.x compatibility
-      run: |
-        sed -i 's/rsmpeg = { version = "0.18.0+ffmpeg.8.0"/rsmpeg = { version = "0.14.2+ffmpeg.6.1"/' src/rust/Cargo.toml
     - name: build
       run: ./build -hardsubx
       working-directory: ./linux
@@ -82,9 +79,6 @@ jobs:
     - uses: actions/checkout@v4
     - name: Install dependencies
       run: sudo apt update && sudo apt install libgpac-dev libtesseract-dev libavformat-dev libavdevice-dev libswscale-dev yasm
-    - name: Downgrade rsmpeg for FFmpeg 6.x compatibility
-      run: |
-        sed -i 's/rsmpeg = { version = "0.18.0+ffmpeg.8.0"/rsmpeg = { version = "0.14.2+ffmpeg.6.1"/' src/rust/Cargo.toml
     - name: cmake
       run: |
         mkdir build && cd build

.github/workflows/build_windows.yml

@@ -58,10 +58,6 @@ jobs:
           override: true
       - name: Install Win 10 SDK
         uses: ilammy/msvc-dev-cmd@v1
-      - name: Downgrade rsmpeg for FFmpeg 7.1.1 compatibility
-        shell: powershell
-        run: |
-          (Get-Content src\rust\Cargo.toml) -replace 'rsmpeg = \{ version = "0.18.0\+ffmpeg.8.0"', 'rsmpeg = { version = "0.17.0+ffmpeg.7.1"' | Set-Content src\rust\Cargo.toml
       - name: build Release-Full
         env:
           LIBCLANG_PATH: "C:\\Program Files\\LLVM\\lib"
@@ -113,10 +109,6 @@ jobs:
           override: true
       - name: Install Win 10 SDK
         uses: ilammy/msvc-dev-cmd@v1
-      - name: Downgrade rsmpeg for FFmpeg 7.1.1 compatibility
-        shell: powershell
-        run: |
-          (Get-Content src\rust\Cargo.toml) -replace 'rsmpeg = \{ version = "0.18.0\+ffmpeg.8.0"', 'rsmpeg = { version = "0.17.0+ffmpeg.7.1"' | Set-Content src\rust\Cargo.toml
       - name: build Debug-Full
         env:
           LIBCLANG_PATH: "C:\\Program Files\\LLVM\\lib"

src/rust/Cargo.toml

@@ -14,9 +14,8 @@ crate-type = ["staticlib"]
 log = "0.4.26"
 env_logger = "0.8.4"
 palette = "0.6.1"
-rsmpeg = { version = "0.18.0+ffmpeg.8.0", optional = true, features = [
-    "link_system_ffmpeg",
-] }
+# Default rsmpeg for macOS and other platforms (FFmpeg 8.0)
+rsmpeg = { version = "=0.18.0", default-features = false, features = ["link_system_ffmpeg"], optional = true }
 tesseract-sys = { version = "0.5.15", optional = true, default-features = false }
 leptonica-sys = { version = "= 0.4.6", optional = true, default-features = false }
 clap = { version = "4.5.31", features = ["derive"] }
@@ -29,6 +28,14 @@ lib_ccxr = { path = "lib_ccxr" }
 url = "2.5.4"
 encoding_rs = "0.8.5"
 
+# Platform-specific rsmpeg configurations (overrides default FFmpeg 8.0)
+# Linux uses FFmpeg 6.1, Windows uses FFmpeg 7.1
+[target.'cfg(target_os = "linux")'.dependencies]
+rsmpeg = { version = "=0.14.2", default-features = false, features = ["link_system_ffmpeg"], optional = true }
+
+[target.'cfg(windows)'.dependencies]
+rsmpeg = { version = "=0.17.0", default-features = false, features = ["link_system_ffmpeg"], optional = true }
+
 [build-dependencies]
 bindgen = "0.64.0"
 pkg-config = "0.3.32"