Merge pull request #1941 from Harshdhall01/cleanup-rust-todos

[RUST] Document EIA-708 buffer size and remove debug logging

Author: cfsmp3

docs/CHANGES.TXT

@@ -1,3 +1,9 @@
+DEVELOPMENT VERSION
+-------------------
+RUST:
+- Documented EIA_708_BUFFER_LENGTH constant with CEA-708 specification reference
+- Removed debug logging from target.rs network module
+
 0.96.3 (2025-12-29)
 -------------------
 - New: VOBSUB subtitle extraction with OCR support for MP4 files

src/rust/lib_ccxr/src/common/constants.rs

@@ -147,7 +147,11 @@ pub const CCX_DECODER_608_SCREEN_WIDTH: usize = 32;
 pub const ONEPASS: usize = 120; // Bytes we can always look ahead without going out of limits
 pub const BUFSIZE: usize = 2048 * 1024 + ONEPASS; // 2 Mb plus the safety pass
 pub const MAX_CLOSED_CAPTION_DATA_PER_PICTURE: usize = 32;
-pub const EIA_708_BUFFER_LENGTH: usize = 2048; // TODO: Find out what the real limit is
+/// CEA-708 Service Input Buffer size.
+/// Specification minimum is 128 bytes per service, but we use 2048 bytes
+/// (16x the minimum) to provide a safety margin for buffer management.
+/// Reference: CEA-708-E Section 8.4.3 - Service Input Buffers
+pub const EIA_708_BUFFER_LENGTH: usize = 2048;
 pub const TS_PACKET_PAYLOAD_LENGTH: usize = 184; // From specs
 pub const SUBLINESIZE: usize = 2048; // Max. length of a .srt line - TODO: Get rid of this
 pub const STARTBYTESLENGTH: usize = 1024 * 1024;

src/rust/lib_ccxr/src/net/target.rs

@@ -82,7 +82,6 @@ impl<'a> SendTarget<'a> {
                 "Unable to connect, address passed is null\n"
             );
         }
-        info!("Target address: {}\n", config.target_addr); // TODO remove this
         info!("Target port: {}\n", config.port.unwrap_or(DEFAULT_TCP_PORT));
         let tcp_stream = TcpStream::connect((
             config.target_addr,