test: Add tests for artifact diagnosis and error_message property

Add tests to improve coverage for the new code:

- TestDiagnoseMissingArtifact: 6 tests covering all code paths
  - Build in progress
  - Build failed
  - Artifact expired (build succeeded but no artifact)
  - No workflow run found
  - Different workflow (wrong workflow name)
  - Exception handling

- TestErrorMessage: 4 tests for Test.error_message property
  - Returns None when no progress entries
  - Returns None when completed successfully
  - Returns message when test is canceled
  - Returns last message from multiple progress entries

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: cfsmp3

tests/test_ci/test_controllers.py

@@ -6,7 +6,8 @@
 from flask import g
 
 from mod_auth.models import Role
-from mod_ci.controllers import (Workflow_builds, get_info_for_pr_comment,
+from mod_ci.controllers import (Workflow_builds, _diagnose_missing_artifact,
+                                get_info_for_pr_comment,
                                 progress_type_request, start_platforms)
 from mod_ci.models import BlockedUsers
 from mod_customized.models import CustomizedTest
@@ -2047,3 +2048,129 @@ def generate_header(data, event, ci_key=None):
             'utf-8'), g.github['ci_key'] if ci_key is None else ci_key)
         headers = generate_git_api_header(event, sig)
         return headers
+
+
+class TestDiagnoseMissingArtifact(BaseTestCase):
+    """Test the _diagnose_missing_artifact function."""
+
+    def test_diagnose_build_in_progress(self):
+        """Test diagnosis when build is still in progress."""
+        mock_repo = MagicMock()
+        mock_log = MagicMock()
+
+        # Mock workflow
+        mock_workflow = MagicMock()
+        mock_workflow.id = 1
+        mock_workflow.name = "Build CCExtractor on Windows"
+        mock_repo.get_workflows.return_value = [mock_workflow]
+
+        # Mock workflow run - in progress
+        mock_run = MagicMock()
+        mock_run.workflow_id = 1
+        mock_run.status = "in_progress"
+        mock_repo.get_workflow_runs.return_value = [mock_run]
+
+        result = _diagnose_missing_artifact(
+            mock_repo, "abc1234", "Build CCExtractor on Windows", mock_log)
+
+        self.assertIn("Build still in progress", result)
+        self.assertIn("in_progress", result)
+
+    def test_diagnose_build_failed(self):
+        """Test diagnosis when build failed."""
+        mock_repo = MagicMock()
+        mock_log = MagicMock()
+
+        mock_workflow = MagicMock()
+        mock_workflow.id = 1
+        mock_workflow.name = "Build CCExtractor on Windows"
+        mock_repo.get_workflows.return_value = [mock_workflow]
+
+        mock_run = MagicMock()
+        mock_run.workflow_id = 1
+        mock_run.status = "completed"
+        mock_run.conclusion = "failure"
+        mock_repo.get_workflow_runs.return_value = [mock_run]
+
+        result = _diagnose_missing_artifact(
+            mock_repo, "abc1234", "Build CCExtractor on Windows", mock_log)
+
+        self.assertIn("Build failed", result)
+        self.assertIn("failure", result)
+
+    def test_diagnose_artifact_expired(self):
+        """Test diagnosis when build succeeded but artifact not found."""
+        mock_repo = MagicMock()
+        mock_log = MagicMock()
+
+        mock_workflow = MagicMock()
+        mock_workflow.id = 1
+        mock_workflow.name = "Build CCExtractor on Windows"
+        mock_repo.get_workflows.return_value = [mock_workflow]
+
+        mock_run = MagicMock()
+        mock_run.workflow_id = 1
+        mock_run.status = "completed"
+        mock_run.conclusion = "success"
+        mock_repo.get_workflow_runs.return_value = [mock_run]
+
+        result = _diagnose_missing_artifact(
+            mock_repo, "abc1234", "Build CCExtractor on Windows", mock_log)
+
+        self.assertIn("Artifact not found", result)
+        self.assertIn("expired", result)
+
+    def test_diagnose_no_workflow_run_found(self):
+        """Test diagnosis when no workflow run exists for commit."""
+        mock_repo = MagicMock()
+        mock_log = MagicMock()
+
+        mock_workflow = MagicMock()
+        mock_workflow.id = 1
+        mock_workflow.name = "Build CCExtractor on Windows"
+        mock_repo.get_workflows.return_value = [mock_workflow]
+
+        # No workflow runs for this commit
+        mock_repo.get_workflow_runs.return_value = []
+
+        result = _diagnose_missing_artifact(
+            mock_repo, "abc1234", "Build CCExtractor on Windows", mock_log)
+
+        self.assertIn("No workflow run found", result)
+        self.assertIn("abc1234", result)
+
+    def test_diagnose_different_workflow(self):
+        """Test diagnosis when only different workflows have run."""
+        mock_repo = MagicMock()
+        mock_log = MagicMock()
+
+        mock_workflow = MagicMock()
+        mock_workflow.id = 1
+        mock_workflow.name = "Build CCExtractor on Linux"
+        mock_repo.get_workflows.return_value = [mock_workflow]
+
+        mock_run = MagicMock()
+        mock_run.workflow_id = 1
+        mock_run.status = "completed"
+        mock_run.conclusion = "success"
+        mock_repo.get_workflow_runs.return_value = [mock_run]
+
+        result = _diagnose_missing_artifact(
+            mock_repo, "abc1234", "Build CCExtractor on Windows", mock_log)
+
+        self.assertIn("No workflow run found", result)
+
+    def test_diagnose_exception_handling(self):
+        """Test diagnosis handles exceptions gracefully."""
+        mock_repo = MagicMock()
+        mock_log = MagicMock()
+
+        # Make get_workflows raise an exception
+        mock_repo.get_workflows.side_effect = Exception("API error")
+
+        result = _diagnose_missing_artifact(
+            mock_repo, "abc1234", "Build CCExtractor on Windows", mock_log)
+
+        self.assertIn("diagnostic check failed", result)
+        self.assertIn("API error", result)
+        mock_log.warning.assert_called_once()

tests/test_test/test_controllers.py

@@ -257,3 +257,52 @@ def test_download_build_log_file(self, mock_g, mock_serve, mock_test, mock_os):
         self.assertEqual(response, mock_serve())
         mock_test.query.filter.assert_called_once()
         mock_os.path.isfile.assert_called_once()
+
+
+class TestErrorMessage(BaseTestCase):
+    """Test the error_message property on Test model."""
+
+    def test_error_message_returns_none_when_not_failed(self):
+        """Test error_message returns None when test has not failed."""
+        from flask import g
+        test = Test.query.get(1)
+        # Test with no progress entries
+        self.assertIsNone(test.error_message)
+
+    def test_error_message_returns_none_when_completed_successfully(self):
+        """Test error_message returns None when test completed successfully."""
+        from flask import g
+        test = Test.query.get(1)
+
+        # Add completed progress
+        progress = TestProgress(test.id, TestStatus.completed, "Test completed")
+        g.db.add(progress)
+        g.db.commit()
+
+        self.assertIsNone(test.error_message)
+
+    def test_error_message_returns_message_when_canceled(self):
+        """Test error_message returns the message when test is canceled."""
+        from flask import g
+        test = Test.query.get(1)
+
+        # Add canceled progress with error message
+        error_msg = "No build artifact found for this commit"
+        progress = TestProgress(test.id, TestStatus.canceled, error_msg)
+        g.db.add(progress)
+        g.db.commit()
+
+        self.assertEqual(test.error_message, error_msg)
+
+    def test_error_message_returns_last_message(self):
+        """Test error_message returns the message from the last progress entry."""
+        from flask import g
+        test = Test.query.get(1)
+
+        # Add multiple progress entries
+        progress1 = TestProgress(test.id, TestStatus.preparation, "Preparing")
+        progress2 = TestProgress(test.id, TestStatus.canceled, "Build failed: workflow finished with failure")
+        g.db.add_all([progress1, progress2])
+        g.db.commit()
+
+        self.assertEqual(test.error_message, "Build failed: workflow finished with failure")