Skip to content

Commit 9b4ca87

Browse files
prateekmediacanihavesomecoffee
authored andcommitted
feat: update PR comment template
1 parent e162a7e commit 9b4ca87

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

templates/ci/pr_comment.txt

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
<b>CCExtractor CI platform</b> finished running the test files on <b>{{platform}}</b>. Below is a summary of the test results{% if comment_info.last_test_master %}, when compared to <a href="{{ url_for('test.by_id', test_id=comment_info.last_test_master.id, _external=True) }}">test for commit {{ comment_info.last_test_master.commit[:7] }}...</a>{% endif %}:
1+
<details>
2+
<summary><b>CCExtractor CI platform</b> finished running the test files on <b>{{platform}}</b>. Below is a summary of the test results{% if comment_info.last_test_master %}, when compared to <a href="{{ url_for('test.by_id', test_id=comment_info.last_test_master.id, _external=True) }}">test for commit {{ comment_info.last_test_master.commit[:7] }}...</a>{% endif %}:</summary>
23
<table>
34
<thead>
45
<td> Report Name </td>
@@ -18,16 +19,12 @@
1819
{% endfor %}
1920
</table>
2021
{% if comment_info.extra_failed_tests | length %}
21-
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).
22-
2322
Your PR breaks these cases:
2423
<ul>
2524
{% for test in comment_info.extra_failed_tests %}
2625
<li> ccextractor {{ test.command }} <a href="{{ url_for('sample.sample_by_id', sample_id=test.sample.id, _external=True) }}">{{ test.sample.sha[:10] }}...</a></li>
2726
{% endfor %}
2827
</ul>
29-
{% else %}
30-
All tests passing on the master branch were passed completely.
3128
{% endif %}
3229
{% if comment_info.common_failed_tests | length %}
3330
NOTE: The following tests have been failing on the master branch as well as the PR:
@@ -46,4 +43,12 @@ Congratulations: Merging this PR would fix the following tests:
4643
</ul>
4744
{% endif %}
4845
<br>
46+
</details>
47+
48+
{% if comment_info.extra_failed_tests | length %}
49+
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).
50+
{% else %}
51+
All tests passing on the master branch were passed completely.
52+
{% endif %}
53+
4954
Check the <a href="{{ url_for('test.by_id', test_id=test_id, _external=True) }}">result</a> page for more info.

0 commit comments

Comments
 (0)