fix: Update test to match master's mark_test_failed implementation

Master uses db.commit() directly instead of safe_db_commit().
Updated test to mock db.commit exception and verify GitHub update
is still attempted.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

Author: cfsmp3

tests/test_ci/test_controllers.py

@@ -2714,24 +2714,26 @@ def test_safe_db_commit_failure_with_rollback_failure(self, mock_log):
         # Two error logs: one for commit failure, one for rollback failure
         self.assertEqual(mock_log.error.call_count, 2)
 
-    @mock.patch('mod_ci.controllers.safe_db_commit')
+    @mock.patch('mod_ci.controllers.update_status_on_github')
     @mock.patch('run.log')
     def test_mark_test_failed_with_db_commit_failure(
-            self, mock_log, mock_safe_commit):
-        """Test mark_test_failed returns False on db commit fail."""
+            self, mock_log, mock_update_github):
+        """Test mark_test_failed returns False when DB commit fails but GitHub succeeds."""
         from mod_test.models import Test
 
-        mock_safe_commit.return_value = False
-
         test = Test.query.first()
         mock_db = MagicMock()
+        mock_db.commit.side_effect = Exception("DB commit failed")
         mock_repo = MagicMock()
 
         result = mark_test_failed(mock_db, test, mock_repo, "Test failed")
 
+        # DB failed but GitHub succeeded, so result is False
         self.assertFalse(result)
         mock_db.add.assert_called_once()
-        mock_safe_commit.assert_called_once()
+        mock_db.commit.assert_called_once()
+        # GitHub update should still be attempted
+        mock_update_github.assert_called_once()
 
     @mock.patch('mod_ci.controllers.time.sleep')
     @mock.patch('run.log')