Skip to content

Commit 897fdd9

Browse files
committed
highlight digest, manifest tag
1 parent 046a624 commit 897fdd9

File tree

4 files changed

+42
-42
lines changed

4 files changed

+42
-42
lines changed

app/lib/client/code/ecr_images.rb

Lines changed: 22 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -157,37 +157,23 @@ def delete_image(tag, image)
157157

158158
def retag_image(tag, newtag, image)
159159
ecracct = ENV.fetch('ECR_ACCOUNT', '')
160-
if ecracct.empty?
161-
resp = @client.batch_get_image(
162-
repository_name: image,
163-
image_ids: [
164-
{
165-
image_tag: tag
166-
}
167-
]
168-
)
169-
@client.put_image(
170-
repository_name: image,
171-
image_manifest: resp.images[0].image_manifest,
172-
image_tag: newtag
173-
)
174-
else
175-
resp = @client.batch_get_image(
176-
registry_id: ecracct,
177-
repository_name: image,
178-
image_ids: [
179-
{
180-
image_tag: tag
181-
}
182-
]
183-
)
184-
@client.put_image(
185-
registry_id: ecracct,
186-
repository_name: image,
187-
image_manifest: resp.images[0].image_manifest,
188-
image_tag: newtag
189-
)
190-
end
160+
options = {
161+
repository_name: image,
162+
image_ids: [
163+
{
164+
image_tag: tag
165+
}
166+
]
167+
}
168+
options[:registry_id] = ecracct unless ecracct.empty?
169+
resp = @client.batch_get_image(options)
170+
options = {
171+
repository_name: image,
172+
image_manifest: resp.images[0].image_manifest,
173+
image_tag: newtag
174+
}
175+
options[:registry_id] = ecracct unless ecracct.empty?
176+
@client.put_image(options)
191177
end
192178

193179
def untag_image(tag, image)
@@ -197,7 +183,9 @@ def untag_image(tag, image)
197183
def get_image_tags_by_digest(image, tag, digest)
198184
arr = []
199185
return arr unless enabled
200-
return arr unless image =~ /^(mrt|merritt)-(dashboard|ingest|store|inventory|audit|replic|admin-sinatra|ops|opswrite)$/
186+
unless image =~ /^(mrt|merritt)-(dashboard|ingest|store|inventory|audit|replic|admin-sinatra|ops|opswrite)$/
187+
return arr
188+
end
201189

202190
begin
203191
options = {
@@ -210,9 +198,8 @@ def get_image_tags_by_digest(image, tag, digest)
210198
}
211199
options[:registry_id] = ENV.fetch('ECR_ACCOUNT', '') unless ENV.fetch('ECR_ACCOUNT', '').empty?
212200
resp = @client.describe_images(options)
213-
if resp.image_details.nil?
214-
return arr
215-
end
201+
return arr if resp.image_details.nil?
202+
216203
resp.image_details.each do |img|
217204
next if img.image_tags.nil?
218205

app/lib/client/resources/ecs.rb

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ def list_services_data
7777
created: date_format(dep.created_at, convert_timezone: true),
7878
updated: date_format(dep.updated_at, convert_timezone: true),
7979
image: [image, digest],
80-
tags: @ecr_client.get_image_tags_by_digest(image_name, image_tag, digest)
80+
tags: @ecr_client.get_image_tags_by_digest(image_name, image_tag, digest),
81+
manifest_tag: UC3S3::ConfigObjectsClient.client.get_ecs_release_manifest_stack_tag(image_name)
8182
}
8283
end
8384
end
@@ -95,10 +96,10 @@ def list_services
9596
AdminUI::Column.new(:desired_count, header: 'Desired'),
9697
AdminUI::Column.new(:running_count, header: 'Running'),
9798
AdminUI::Column.new(:pending_count, header: 'Pending'),
98-
AdminUI::Column.new(:created, header: 'Created'),
9999
AdminUI::Column.new(:updated, header: 'Updated'),
100100
AdminUI::Column.new(:image, header: 'Image'),
101-
AdminUI::Column.new(:tags, header: 'Matching Tags')
101+
AdminUI::Column.new(:tags, header: 'Matching Tags'),
102+
AdminUI::Column.new(:manifest_tag, header: 'Manifest Tag')
102103
]
103104
)
104105
return table unless enabled
@@ -281,10 +282,7 @@ def retag_and_redeploy_service(service)
281282

282283
repo = service == 'ui' ? 'mrt-dashboard' : "mrt-#{service}"
283284

284-
tag = UC3S3::ConfigObjectsClient.client.get_ecs_release_manifest
285-
.fetch('ecs-tagmap', {})
286-
.fetch(repo, {})
287-
.fetch(UC3::UC3Client.stack_name, '')
285+
tag = UC3S3::ConfigObjectsClient.client.get_ecs_release_manifest_stack_tag(repo)
288286

289287
UC3Code::SourceCodeClient.client.retag_image(tag, UC3::UC3Client.stack_name, repo) unless tag.empty?
290288

app/lib/client/s3/config_objects.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,14 @@ def get_ecs_release_manifest_deploy_tags(reposhort)
317317
tags.uniq
318318
end
319319

320+
def get_ecs_release_manifest_repo_map(repo)
321+
get_ecs_release_manifest.fetch('ecs-tagmap', {}).fetch(repo, {})
322+
end
323+
324+
def get_ecs_release_manifest_stack_tag(repo)
325+
get_ecs_release_manifest_repo_map(repo).fetch(UC3::UC3Client.stack_name, '')
326+
end
327+
320328
def get_ec2_release_manifest_deploy_tags(reposhort)
321329
tags = []
322330
%w[prd stg].each do |env|

app/public/admintool.css

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,12 @@ div#controls {
152152
span.val {
153153
display: block;
154154
}
155+
156+
td.image span.val:nth-of-type(2), td.digest {
157+
max-width: 130px;
158+
display: inline-block;
159+
color: green;
160+
}
155161
span.inline {
156162
display: inline;
157163
}
@@ -182,6 +188,7 @@ td.images span.val {
182188
display: list-item;
183189
}
184190

191+
td.image, th.image,
185192
td.object_count, th.object_count,
186193
td.total_files, th.total_files,
187194
td.num_colls, th.num_colls,

0 commit comments

Comments
 (0)