Updating unit tests

Author: jacob6838

tests/data/raw_to_standard/planned_events_test_expected_results.py

@@ -345,6 +345,7 @@
                 "beginning_cross_street": "CO 65",
                 "ending_cross_street": "US 6",
                 "valid": False,
+                "vehicle_impact": "all-lanes-closed",
             },
         },
     }

tests/data/standard_to_wzdx/planned_events_translator_data.py

@@ -32,6 +32,7 @@
             "types_of_work": [
                 {"type_name": "below-road-work", "is_architectural_change": True}
             ],
+            "vehicle_impact": "some-lanes-closed",
         },
     },
 }
@@ -108,6 +109,7 @@
             "restrictions": [],
             "beginning_milepost": 50.0,
             "ending_milepost": 60.0,
+            "vehicle_impact": "some-lanes-closed",
         },
     },
 }

tests/raw_to_standard/planned_events_test.py

@@ -224,6 +224,55 @@ def test_get_lanes_list_2():
     )
 
 
+# --------------------------------------------------------------------------------Unit test for get_vehicle_impact function--------------------------------------------------------------------------------
+def test_get_vehicle_impact_some_lanes_closed():
+    lanes = [
+        {"order": 1, "type": "shoulder", "status": "open"},
+        {"order": 2, "type": "general", "status": "closed"},
+        {"order": 3, "type": "general", "status": "closed"},
+        {"order": 4, "type": "shoulder", "status": "open"},
+    ]
+    test_vehicle_impact = planned_events.get_vehicle_impact(lanes, False)
+    expected_vehicle_impact = "some-lanes-closed"
+    assert test_vehicle_impact == expected_vehicle_impact
+
+
+def test_get_vehicle_impact_all_lanes_closed():
+    lanes = [
+        {"order": 1, "type": "shoulder", "status": "closed"},
+        {"order": 2, "type": "general", "status": "closed"},
+        {"order": 3, "type": "general", "status": "closed"},
+        {"order": 4, "type": "shoulder", "status": "closed"},
+    ]
+    test_vehicle_impact = planned_events.get_vehicle_impact(lanes, False)
+    expected_vehicle_impact = "all-lanes-closed"
+    assert test_vehicle_impact == expected_vehicle_impact
+
+
+def test_get_vehicle_impact_all_lanes_open():
+    lanes = [
+        {"order": 1, "type": "shoulder", "status": "open"},
+        {"order": 2, "type": "general", "status": "open"},
+        {"order": 3, "type": "general", "status": "open"},
+        {"order": 4, "type": "shoulder", "status": "open"},
+    ]
+    test_vehicle_impact = planned_events.get_vehicle_impact(lanes, False)
+    expected_vehicle_impact = "all-lanes-open"
+    assert test_vehicle_impact == expected_vehicle_impact
+
+
+def test_get_vehicle_impact_alternating_description_valid():
+    lanes = [
+        {"order": 1, "type": "shoulder", "status": "open"},
+        {"order": 2, "type": "general", "status": "closed"},
+        {"order": 3, "type": "general", "status": "open"},
+        {"order": 4, "type": "shoulder", "status": "closed"},
+    ]
+    test_vehicle_impact = planned_events.get_vehicle_impact(lanes, True)
+    expected_vehicle_impact = "alternating-one-way"
+    assert test_vehicle_impact == expected_vehicle_impact
+
+
 def test_is_incident_true_true():
     msg = {
         "properties": {"id": "OpenTMS-Incident2028603626", "type": "Emergency Roadwork"}
@@ -313,6 +362,25 @@ def test_is_incident_wz_false_2():
     assert actual == (False, False)
 
 
+def test_detect_alternating_traffic_true():
+    additional_impacts = ["Alternating traffic", "Alternating Lanes"]
+    assert planned_events.detect_alternating_traffic(additional_impacts)
+
+    additional_impacts = ["Alternating traffic"]
+    assert planned_events.detect_alternating_traffic(additional_impacts)
+
+
+def test_detect_alternating_traffic_false():
+    additional_impacts = None
+    assert not planned_events.detect_alternating_traffic(additional_impacts)
+
+    additional_impacts = []
+    assert not planned_events.detect_alternating_traffic(additional_impacts)
+
+    additional_impacts = ["other impact"]
+    assert not planned_events.detect_alternating_traffic(additional_impacts)
+
+
 class MockGeospatialApi:
     def __init__(
         self, getCachedRequest=lambda x: None, setCachedRequest=lambda x, y: None

tests/standard_to_wzdx/planned_events_translator_test.py

@@ -63,88 +63,6 @@ def test_parse_work_zone_invalid_data():
     assert test_feature == None
 
 
-# --------------------------------------------------------------------------------Unit test for get_vehicle_impact function--------------------------------------------------------------------------------
-def test_get_vehicle_impact_some_lanes_closed():
-    lanes = [
-        {"order": 1, "type": "shoulder", "status": "open"},
-        {"order": 2, "type": "general", "status": "closed"},
-        {"order": 3, "type": "general", "status": "closed"},
-        {"order": 4, "type": "shoulder", "status": "open"},
-    ]
-    test_vehicle_impact = planned_events_translator.get_vehicle_impact(
-        lanes, "description"
-    )
-    expected_vehicle_impact = "some-lanes-closed"
-    assert test_vehicle_impact == expected_vehicle_impact
-
-
-def test_get_vehicle_impact_all_lanes_closed():
-    lanes = [
-        {"order": 1, "type": "shoulder", "status": "closed"},
-        {"order": 2, "type": "general", "status": "closed"},
-        {"order": 3, "type": "general", "status": "closed"},
-        {"order": 4, "type": "shoulder", "status": "closed"},
-    ]
-    test_vehicle_impact = planned_events_translator.get_vehicle_impact(
-        lanes, "description"
-    )
-    expected_vehicle_impact = "all-lanes-closed"
-    assert test_vehicle_impact == expected_vehicle_impact
-
-
-def test_get_vehicle_impact_all_lanes_open():
-    lanes = [
-        {"order": 1, "type": "shoulder", "status": "open"},
-        {"order": 2, "type": "general", "status": "open"},
-        {"order": 3, "type": "general", "status": "open"},
-        {"order": 4, "type": "shoulder", "status": "open"},
-    ]
-    test_vehicle_impact = planned_events_translator.get_vehicle_impact(
-        lanes, "description"
-    )
-    expected_vehicle_impact = "all-lanes-open"
-    assert test_vehicle_impact == expected_vehicle_impact
-
-
-def test_get_vehicle_impact_alternating_description_valid():
-    lanes = [
-        {"order": 1, "type": "shoulder", "status": "open"},
-        {"order": 2, "type": "general", "status": "closed"},
-        {"order": 3, "type": "general", "status": "open"},
-        {"order": 4, "type": "shoulder", "status": "closed"},
-    ]
-    test_vehicle_impact = planned_events_translator.get_vehicle_impact(
-        lanes,
-        "Between Utopia Place and CO 14 (Laporte) from Mile Point 354.5 to Mile Point 355.7. Paving operations. Alternating traffic. "
-        "Starting June 5, 2025 at 7:00AM MDT until June 5, 2025 at about 5:00PM MDT. Full schedule below: \u2022 June 5, 7:00AM - "
-        "June 5, 5:00PM Comment: Delays of up to 15 minutes can be anticipated. The speed limit will be reduced to 40 mph through the "
-        "work zone. More project information is available at 970-632-7440 or sherry@sawpr.com.",
-    )
-    expected_vehicle_impact = "alternating-one-way"
-    assert test_vehicle_impact == expected_vehicle_impact
-
-
-def test_get_vehicle_impact_alternating_comment_invalid():
-    lanes = [
-        {"order": 1, "type": "shoulder", "status": "open"},
-        {"order": 2, "type": "general", "status": "closed"},
-        {"order": 3, "type": "general", "status": "open"},
-        {"order": 4, "type": "shoulder", "status": "closed"},
-    ]
-    test_vehicle_impact = planned_events_translator.get_vehicle_impact(
-        lanes,
-        "Between 3300 Road and Pleasure Park Road (1 to 4 miles west of Hotchkiss) from Mile Point 18.9 to Mile Point 15.6. "
-        "Road construction. Starting June 5, 2025 at 6:01AM MDT until June 5, 2025 at about 6:00PM MDT. Full schedule below: "
-        "\u2022 June 5, 6:01AM - June 5, 6:00PM Comment: Shoulder widening will start on the north side. Crews continue pipe "
-        "installation and waterline work between Mile Point 15-16 in both the eastbound and westbound direction. Alternating "
-        "single lane traffic under flagger control will be implemented throughout the work zone and delays are expected during "
-        "peak commuter times. Motorists should expect delays through the work zone. There will be one lane alternating traffic "
-        "during the majority of the project and shoulder closures as needed and periodic traffic stops in order to move equipment.",
-    )
-    expected_vehicle_impact = "some-lanes-closed"
-    assert test_vehicle_impact == expected_vehicle_impact
-
-
 # --------------------------------------------------------------------------------Unit test for wzdx_creator function--------------------------------------------------------------------------------
 @patch.dict(
     os.environ,

tests/tools/cdot_geospatial_api_test.py

@@ -89,8 +89,8 @@ def test_get_route_between_measures():
 
 def test_get_route_between_measures_allow_reversal():
     routeId = "070A"
-    startMeasure = 50
-    endMeasure = 60
+    startMeasure = 60
+    endMeasure = 50
     actual = cdot_geospatial_api.GeospatialApi().get_route_between_measures(
         routeId, startMeasure, endMeasure, compressed=True
     )

wzdx/raw_to_standard/planned_events.py

@@ -558,7 +558,7 @@ def update_lanes_alternating_traffic(lanes: list[dict]) -> list[dict]:
     return lanes
 
 
-def detect_alternating_traffic(lane_impacts: list[dict]) -> bool:
+def detect_alternating_traffic(additional_impacts: list[dict]) -> bool:
     """Check if there are any lane impacts indicating alternating traffic
 
     Args:
@@ -567,9 +567,9 @@ def detect_alternating_traffic(lane_impacts: list[dict]) -> bool:
     Returns:
         bool: whether there are any alternating traffic impacts
     """
-    if not lane_impacts:
+    if not additional_impacts:
         return False
-    return "Alternating traffic" in lane_impacts
+    return "Alternating traffic" in additional_impacts
 
 
 def get_lane_impacts(

wzdx/sample_files/standard/planned_events/standard_planned_event_OpenTMS-Event20643308360_westbound.json

@@ -15,70 +15,22 @@
       "last_updated_timestamp": 1731013775261
     },
     "geometry": [
-      [
-        -105.16586083999994,
-        39.734858632000055
-      ],
-      [
-        -105.16638882599995,
-        39.73443766200006
-      ],
-      [
-        -105.16854799099997,
-        39.73271605700006
-      ],
-      [
-        -105.17077491299995,
-        39.73094029200007
-      ],
-      [
-        -105.17293965199997,
-        39.72943332800003
-      ],
-      [
-        -105.17468559199995,
-        39.72842892500006
-      ],
-      [
-        -105.17580481399995,
-        39.727785029000074
-      ],
-      [
-        -105.17843878399998,
-        39.72609999900004
-      ],
-      [
-        -105.17993813899994,
-        39.72512450600004
-      ],
-      [
-        -105.18206644899999,
-        39.723739730000034
-      ],
-      [
-        -105.18563422299997,
-        39.72141816000004
-      ],
-      [
-        -105.18769294899994,
-        39.72000476800008
-      ],
-      [
-        -105.18847369599996,
-        39.71936694800007
-      ],
-      [
-        -105.18984140499998,
-        39.718052475000036
-      ],
-      [
-        -105.190781717,
-        39.71695507100003
-      ],
-      [
-        -105.19270413899994,
-        39.714462801000025
-      ]
+      [-105.16586083999994, 39.734858632000055],
+      [-105.16638882599995, 39.73443766200006],
+      [-105.16854799099997, 39.73271605700006],
+      [-105.17077491299995, 39.73094029200007],
+      [-105.17293965199997, 39.72943332800003],
+      [-105.17468559199995, 39.72842892500006],
+      [-105.17580481399995, 39.727785029000074],
+      [-105.17843878399998, 39.72609999900004],
+      [-105.17993813899994, 39.72512450600004],
+      [-105.18206644899999, 39.723739730000034],
+      [-105.18563422299997, 39.72141816000004],
+      [-105.18769294899994, 39.72000476800008],
+      [-105.18847369599996, 39.71936694800007],
+      [-105.18984140499998, 39.718052475000036],
+      [-105.190781717, 39.71695507100003],
+      [-105.19270413899994, 39.714462801000025]
     ],
     "header": {
       "description": "Between Exit 263: Colorado Mills Parkway (West Pleasant View) and C-470 (Golden) from Mile Point 262 to Mile Point 260. Both shoulders closed due to road construction. Starting November 12, 2024 at 7:00AM MST until November 12, 2024 at about 6:00PM MST. Full schedule below: \u00e2\u20ac\u00a2 November 12, 7:00AM - November 12, 6:00PM",
@@ -124,6 +76,7 @@
       "beginning_cross_street": "Exit 263: Colorado Mills Parkway (West Pleasant View)",
       "ending_cross_street": "C-470 (Golden)",
       "valid": false,
+      "vehicle_impact": "some-lanes-closed",
       "route_details_start": {
         "Route": "070A_DEC",
         "Measure": 262.0,
@@ -141,4 +94,4 @@
       "condition_1": true
     }
   }
-}
+}