Bugfix/spring upgrade by Michael7371 · Pull Request #217 · CDOT-CV/jpo-ode

Michael7371 · 2025-08-20T00:11:14Z

PR Details

Description

This PR updates the spring boot dependencies for the ODE, and it's primary maven modules from version 3.1.3 to 3.5.4. The primary breaking change was involving the embedded Kafka broker. Outside of that, some dependencies have updated versions to allow for compatibility with spring boot.

Related Issue

Motivation and Context

To keep the ODE up to date with spring boot updates and security fixes.

How Has This Been Tested?

Tests run and pass
UDP receiver runs properly
/tim REST endpoint creates a TIM message on kafka topic topic.OdeTimJsonTMCFiltered

Types of changes

Defect fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that cause existing functionality to change)

Checklist:

I have added any new packages to the sonar-scanner.properties file
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
ODE Contributing Guide
I have added tests to cover my changes.
All new and existing tests passed.

… holder

jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/udp/AbstractUdpReceiverPublisher.java

jpo-ode-core/pom.xml

drewjj

My tests did catch on the TimDepositControllerTest but on a second run all the tests worked. This is similar to how the encoder tests act sometimes so I don't think this is an issue. The majority of the changes seem to be white space changes. One comment regarding a commented out line but that's about it. Nice!

jpo-ode-svcs/src/main/resources/application.yaml

drewjj

Looks great!

mcook42 · 2025-08-29T21:43:42Z

jpo-ode-svcs/src/test/java/us/dot/its/jpo/ode/test/utilities/EmbeddedKafkaHolder.java

    if (!started) {
-      try {
-        embeddedKafka.kafkaPorts(4242);
-        embeddedKafka.afterPropertiesSet();
-      } catch (Exception e) {
-        throw new KafkaException("Embedded broker failed to start", e);
+      synchronized (EmbeddedKafkaHolder.class) {
+        if (!started) {


question(blocking): do we need both !started checks, or can one be removed?

Good catch, this is resolved now.

mcook42 · 2025-08-29T21:47:25Z

issue(blocking): I've gotten the same test failure a few times locally. Have you gotten this same failure? I would refer to the CI build to see if it's an issue with my machine, but it doesn't look like we run tests in the CI anymore.

[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.773 s -- in us.dot.its.jpo.ode.udp.sdsm.SdsmReceiverTest
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   Asn1DecodedDataRouterTest.testAsn1DecodedDataRouterTIMDataFlow:153 » IllegalState More than one record for topic found
[INFO] 
[ERROR] Tests run: 342, Failures: 0, Errors: 1, Skipped: 0

mcook42

This all looks good to me, but I have a blocking question and issue (noted separately). Once those are resolved, I'm good to approve. Thanks for this work!

mcook42 · 2025-08-29T22:38:47Z

issue(blocking): I've gotten the same test failure a few times locally. Have you gotten this same failure? I would refer to the CI build to see if it's an issue with my machine, but it doesn't look like we run tests in the CI anymore.
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.773 s -- in us.dot.its.jpo.ode.udp.sdsm.SdsmReceiverTest
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   Asn1DecodedDataRouterTest.testAsn1DecodedDataRouterTIMDataFlow:153 » IllegalState More than one record for topic found
[INFO] 
[ERROR] Tests run: 342, Failures: 0, Errors: 1, Skipped: 0

It looks like this is an existing test failure, so I won't block this PR on this issue

See https://github.com/CDOT-CV/jpo-ode/actions/runs/17335293330/job/49220250166?pr=218

Michael7371 · 2025-09-02T16:13:02Z

issue(blocking): I've gotten the same test failure a few times locally. Have you gotten this same failure? I would refer to the CI build to see if it's an issue with my machine, but it doesn't look like we run tests in the CI anymore.
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.773 s -- in us.dot.its.jpo.ode.udp.sdsm.SdsmReceiverTest
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   Asn1DecodedDataRouterTest.testAsn1DecodedDataRouterTIMDataFlow:153 » IllegalState More than one record for topic found
[INFO] 
[ERROR] Tests run: 342, Failures: 0, Errors: 1, Skipped: 0
It looks like this is an existing test failure, so I won't block this PR on this issue

See https://github.com/CDOT-CV/jpo-ode/actions/runs/17335293330/job/49220250166?pr=218

Interesting, I am not getting that error locally. I am running the tests in PowerShell and not WSL, so maybe that's part of the reason? @drewjj Do you get the error locally?

Michael7371 added 4 commits August 14, 2025 17:32

updating spring boot version to 3.5.4 and fixing kafka embedded kafka…

6f0ef45

… holder

fixing asn1 encoded data router unit tests

9e59c46

updates to unit tests with updated spring boot version

193b766

fix error in AbstractUdpReceiverPublisher

eb2e378

github-actions bot reviewed Aug 20, 2025

View reviewed changes

jpo-ode-svcs/src/main/java/us/dot/its/jpo/ode/udp/AbstractUdpReceiverPublisher.java Outdated Show resolved Hide resolved

Michael7371 added 5 commits August 20, 2025 09:50

adding ssl bean to tests

9cd1efc

chore: checkstyle updates

a20b631

reverting ssl config

9514d35

reverting formatting changes

b2a83c7

reverting formatting changes to the asn1encodeddatarouter

d9c8887

Michael7371 commented Aug 28, 2025

View reviewed changes

jpo-ode-core/pom.xml Show resolved Hide resolved

Michael7371 requested a review from drewjj August 28, 2025 22:13

Michael7371 marked this pull request as ready for review August 28, 2025 22:13

Michael7371 requested a review from mcook42 August 28, 2025 22:13

drewjj approved these changes Aug 29, 2025

View reviewed changes

jpo-ode-svcs/src/main/resources/application.yaml Outdated Show resolved Hide resolved

reverting changes to application.yml

600c3be

Michael7371 requested a review from drewjj August 29, 2025 16:42

drewjj approved these changes Aug 29, 2025

View reviewed changes

mcook42 reviewed Aug 29, 2025

View reviewed changes

mcook42 requested changes Aug 29, 2025

View reviewed changes

removal of redundant start check in embedded kafka getter

af5fcbe

mcook42 approved these changes Sep 2, 2025

View reviewed changes

Michael7371 merged commit 4d39c9c into dev Sep 4, 2025
4 checks passed

Michael7371 deleted the bugfix/spring-upgrade branch September 4, 2025 20:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix/spring upgrade#217

Bugfix/spring upgrade#217
Michael7371 merged 11 commits intodevfrom
bugfix/spring-upgrade

Michael7371 commented Aug 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

drewjj left a comment

Uh oh!

Uh oh!

drewjj left a comment

Uh oh!

mcook42 Aug 29, 2025

Uh oh!

Michael7371 Sep 2, 2025

Uh oh!

mcook42 commented Aug 29, 2025

Uh oh!

mcook42 left a comment

Uh oh!

mcook42 commented Aug 29, 2025

Uh oh!

Michael7371 commented Sep 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Michael7371 commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

Uh oh!

Uh oh!

Uh oh!

drewjj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

drewjj left a comment

Choose a reason for hiding this comment

Uh oh!

mcook42 Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Michael7371 Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

mcook42 commented Aug 29, 2025

Uh oh!

mcook42 left a comment

Choose a reason for hiding this comment

Uh oh!

mcook42 commented Aug 29, 2025

Uh oh!

Michael7371 commented Sep 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Michael7371 commented Aug 20, 2025 •

edited

Loading