Fix: run tests in ci.yml without sonar when not in USDOT-owned branch#218
Merged
Fix: run tests in ci.yml without sonar when not in USDOT-owned branch#218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Description
Run tests in ci.yml without Sonar when not in a USDOT-owned branch. The existing CI only runs tests in the
sonarstep, which only runs when USDOT owns the branch. This means we don't get the value of automatic tests and PR blockers if tests fail. This replaces the automated testing without doubling our test costs when targeting a USDOT-owned branch.Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
ODE Contributing Guide