gui: Prevent HexWidget data overwrite from changing the length of the buffer

Author: calc84maniac

gui/qt/debugger/hexwidget.cpp

@@ -293,11 +293,12 @@ void HexWidget::overwrite(int addr, char c) {
     m_modified[address] = m_modified[address] + 1;
 }
 
-void HexWidget::overwrite(int addr, int len, const QByteArray &ba) {
+void HexWidget::overwrite(int addr, const QByteArray &ba) {
     int address = addr / 2;
-    stack_entry_t entry{addr, m_data.mid(address, len)};
-    m_stack.push(entry);
-    m_data.replace(address, len, ba);
+    stack_entry_t entry{addr, m_data.mid(address, ba.size())};
+    int len = entry.ba.size();
+    m_stack.push(std::move(entry));
+    m_data.replace(address, len, QByteArray::fromRawData(ba.constData(), len));
     for (int i = address; i < address + len; i++) {
         m_modified[i] = m_modified[i] + 1;
     }
@@ -486,7 +487,7 @@ void HexWidget::keyPressEvent(QKeyEvent *event) {
         if (!m_asciiEdit) {
             ba = QByteArray::fromHex(ba);
         }
-        overwrite(addr, ba.size(), ba);
+        overwrite(addr, ba);
         setCursorOffset(addr + ba.size() * 2);
     } else
     if (event->matches(QKeySequence::Delete)) {

gui/qt/debugger/hexwidget.h

@@ -58,9 +58,9 @@ private slots:
     void setSelection(int addr);
     void resetSelection() { m_selectStart = m_selectEnd = -1; }
     bool isSelected() const { return m_selectStart != -1; }
-    void setSelected(char n) { overwrite(m_selectStart * 2, m_selectLen, QByteArray(m_selectLen, n)); }
+    void setSelected(char n) { overwrite(m_selectStart * 2, QByteArray(m_selectLen, n)); }
     void overwrite(int pos, char c);
-    void overwrite(int pos, int len, const QByteArray &ba);
+    void overwrite(int pos, const QByteArray &ba);
     int getPosition(QPoint posa, bool allow = true);
 
     typedef struct {