debugger: minor code fixes and drop reqs to C++14 instead of C++20.

Author: adriweb

gui/qt/debugger.cpp

@@ -1986,7 +1986,7 @@ void MainWindow::gotoPressed() {
         QString resolved = resolveAddressOrEquate(typed, &ok);
         if (ok) {
             m_gotoAddr = typed;
-            disasmUpdateAddr(static_cast<int>(hex2int(resolved)), false);
+            disasmUpdateAddr(hex2int(resolved), false);
 
             auto &hist = m_disasmGotoHistory;
             hist.erase(std::remove_if(hist.begin(), hist.end(), [&](const QString &s){ return s.compare(typed, Qt::CaseInsensitive) == 0; }), hist.end());

gui/qt/memorywidget.cpp

@@ -117,7 +117,7 @@ void MainWindow::flashGotoPressed() {
             ui->flashEdit->setOffset(hex2int(resolved));
 
             auto &hist = m_memGotoHistory;
-            std::erase_if(hist, [&](const QString &s){ return s.compare(typed, Qt::CaseInsensitive) == 0; });
+            hist.erase(std::remove_if(hist.begin(), hist.end(), [&](const QString &s){ return s.compare(typed, Qt::CaseInsensitive) == 0; }), hist.end());
             hist.insert(hist.begin(), typed);
             if (hist.size() > 50) { hist.resize(50); }
         } else {
@@ -138,7 +138,7 @@ void MainWindow::ramGotoPressed() {
             ui->ramEdit->setOffset(hex2int(resolved) - 0xD00000);
 
             auto &hist = m_memGotoHistory;
-            std::erase_if(hist, [&](const QString &s){ return s.compare(typed, Qt::CaseInsensitive) == 0; });
+            hist.erase(std::remove_if(hist.begin(), hist.end(), [&](const QString &s){ return s.compare(typed, Qt::CaseInsensitive) == 0; }), hist.end());
             hist.insert(hist.begin(), typed);
             if (hist.size() > 50) { hist.resize(50); }
         } else {

gui/qt/utils.cpp

@@ -68,9 +68,10 @@ QString resolveAddressOrEquate(const QString &input, bool *ok) {
         return {};
     }
 
-    if (QString equ = getAddressOfEquate(in.toStdString()); !equ.isEmpty()) {
+    QString addr = getAddressOfEquate(in.toStdString());
+    if (!addr.isEmpty()) {
         if (ok) { *ok = true; }
-        return equ;
+        return addr;
     }
 
     QString s = in;
@@ -80,8 +81,7 @@ QString resolveAddressOrEquate(const QString &input, bool *ok) {
     if (s.isEmpty() || s.length() > 6) {
         return {};
     }
-    std::string ss = s.toStdString();
-    if (ss.find_first_not_of("0123456789ABCDEF") != std::string::npos) {
+    if (s.toStdString().find_first_not_of("0123456789ABCDEF") != std::string::npos) {
         return {};
     }