swapped the transparent and opaque loops to improve worst case transparent performance

Author: ZERICO2005

src/graphx/graphx.asm

@@ -4881,8 +4881,8 @@ gfx_RotatedScaledSprite_NoClip:
 ; Returns:
 ;  arg1 : Pointer to sprite struct output
 	ld	a, -1 + _RotatedScaledSprite_NoClip.inner_opaque - _RotatedScaledSprite_NoClip.dsrs_jump_1
-	; push hl \ ld l, a \ inc l
-	ld	bc, $2C6FE5
+	; jr .inner_opaque_hijack \ inc l
+	ld	bc, ($2C0018) or (((-1 + _RotatedScaledSprite_NoClip.inner_opaque_hijack - _RotatedScaledSprite_NoClip.dsrs_jump_2) and $FF) shl 8)
 	jr	_RotatedScaledSprite_NoClip
 ;-------------------------------------------------------------------------------
 gfx_RotatedScaledTransparentSprite_NoClip:
@@ -4895,8 +4895,8 @@ gfx_RotatedScaledTransparentSprite_NoClip:
 ; Returns:
 ;  arg1 : Pointer to sprite struct output
 	ld	a, -1 + _RotatedScaledSprite_NoClip.inner_transparent - _RotatedScaledSprite_NoClip.dsrs_jump_1
-	; jr .inner_transparent_hijack \ inc l
-	ld	bc, ($2C0018) or (((-1 + _RotatedScaledSprite_NoClip.inner_transparent_hijack - _RotatedScaledSprite_NoClip.dsrs_jump_2) and $FF) shl 8)
+	; push hl \ ld l, a \ inc l
+	ld	bc, $2C6FE5
 _RotatedScaledSprite_NoClip:
 	ld	iy, .dsrs_base_address
 	ld	(iy + (_RotatedScaledSprite_NoClip.dsrs_jump_1 - .dsrs_base_address)), a
@@ -5047,13 +5047,13 @@ _RotatedScaledSprite_NoClip:
 
 ;-------------------------------------------------------------------------------
 
-.inner_transparent:
+.inner_opaque:
 	cp	a, h
 	jr	c, .skip_pixel
 	ld	c, ixh
 	cp	a, c
 	jr	c, .skip_pixel
-.inner_transparent_hijack:
+.inner_opaque_hijack:
 	; get pixel and draw to buffer
 	push	hl			; xs
 	ld	l, a
@@ -5064,30 +5064,21 @@ _RotatedScaledSprite_NoClip:
 	add	hl, bc			; y * size + x
 
 	ld	bc, 0
-.dsrs_sprptr_0A := $-3
+.dsrs_sprptr_0B := $-3
 	add	hl, bc
-	ld	b, a	; preserve A
-	ld	a, (hl)
-	cp	a, TRASPARENT_COLOR
-smcByte _TransparentColor
-	jr	z, .transparent_pixel
-	ld	(de), a
-.transparent_pixel:
-	ld	a, b	; restore A
-	pop	hl			; ys
-.skip_pixel:
-	inc	de			; x++s
+	ldi
+	pop	hl
+
 	ld	bc, 0			; smc = -sinf
-.dsrs_sinf_0A := $-3
+.dsrs_sinf_0B := $-3
 	add	hl, bc			; ys += -sinf
 
 	ld	bc, 0			; smc = cosf
-.dsrs_cosf_0A := $-3
+.dsrs_cosf_0B := $-3
 	add	ix, bc			; xs += cosf
 
 	dec	iyl
-	jr	nz, .inner_transparent		; x loop
-.dsrs_jump_1 := $-1
+	jr	nz, .inner_opaque	; x loop
 
 	dec	iyh	
 	jr	z, .finish		; y loop
@@ -5112,14 +5103,14 @@ smcByte _TransparentColor
 .begin_loop:
 .dsrs_size_1 := $+2			; smc = size * scale / 64
 	ld	iyl, 0
-.inner_opaque:
+.inner_transparent:
 	cp	a, h
 	jr	c, .skip_pixel
 	ld	c, ixh
 	cp	a, c
 	jr	c, .skip_pixel
 	; get pixel and draw to buffer
-	; SMC: push hl \ ld l, a --> jr inner_transparent_hijack
+	; SMC: push hl \ ld l, a --> jr inner_opaque_hijack
 	push	hl			; xs
 	ld	l, a
 .dsrs_jump_2 := $-1
@@ -5130,21 +5121,30 @@ smcByte _TransparentColor
 	add	hl, bc			; y * size + x
 
 	ld	bc, 0
-.dsrs_sprptr_0B := $-3
+.dsrs_sprptr_0A := $-3
 	add	hl, bc
-	ldi
-	pop	hl
-
+	ld	b, a	; preserve A
+	ld	a, (hl)
+	cp	a, TRASPARENT_COLOR
+smcByte _TransparentColor
+	jr	z, .transparent_pixel
+	ld	(de), a
+.transparent_pixel:
+	ld	a, b	; restore A
+	pop	hl			; ys
+.skip_pixel:
+	inc	de			; x++s
 	ld	bc, 0			; smc = -sinf
-.dsrs_sinf_0B := $-3
+.dsrs_sinf_0A := $-3
 	add	hl, bc			; ys += -sinf
 
 	ld	bc, 0			; smc = cosf
-.dsrs_cosf_0B := $-3
+.dsrs_cosf_0A := $-3
 	add	ix, bc			; xs += cosf
 
 	dec	iyl
-	jr	nz, .inner_opaque	; x loop
+	jr	nz, .inner_transparent	; x loop
+.dsrs_jump_1 := $-1
 
 	dec	iyh
 	jr	nz, .outer		; y loop