Skip to content

Commit 9a3208d

Browse files
authored
Fix: missing record.task_id for descendant loggers (e.g. karton.<identity>.module) (#311)
1 parent 2cc097d commit 9a3208d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

karton/core/base.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,11 +131,11 @@ def setup_logger(self, level: Optional[Union[str, int]] = None) -> None:
131131
if not self.identity:
132132
raise ValueError("Can't setup logger without identity")
133133

134+
task_context_filter = TaskContextFilter()
134135
self._log_handler.setFormatter(logging.Formatter())
136+
self._log_handler.addFilter(task_context_filter)
135137

136138
logger = logging.getLogger(self.identity)
137-
logger.addFilter(TaskContextFilter())
138-
139139
if logger.handlers:
140140
# If logger already have handlers set: clear them
141141
logger.handlers.clear()
@@ -148,6 +148,7 @@ def setup_logger(self, level: Optional[Union[str, int]] = None) -> None:
148148
logger.setLevel(log_level)
149149
stream_handler = logging.StreamHandler()
150150
stream_handler.setFormatter(logging.Formatter(self._log_format))
151+
stream_handler.addFilter(task_context_filter)
151152
logger.addHandler(stream_handler)
152153

153154
if not self.debug and self.enable_publish_log:

0 commit comments

Comments
 (0)