Update CVE items to be unique and update tests see #905 (#914)

Author: ahouseholder

data/schema/v2/Decision_Point_Value_Selection-2-0-0.schema.json

@@ -191,7 +191,8 @@
         "type": "string"
       },
       "minItems": 1,
-      "type": "array"
+      "type": "array",
+      "uniqueItems": true
     },
     "selections": {
       "title": "Selections",

src/ssvc/selection.py

@@ -224,6 +224,7 @@ class SelectionList(_Timestamped, BaseModel):
             ["VU#999999", "GHSA-0123-4567-89ab"],
         ],
         min_length=1,
+        json_schema_extra={"uniqueItems": True},
     )
     selections: list[Selection] = Field(
         ...,
@@ -297,6 +298,8 @@ def validate_target_ids(
         for item in value:
             if not isinstance(item, str):
                 raise ValueError("Each target_id must be a string.")
+        if len(value) != len(set(value)):
+            raise ValueError("target_ids must not contain duplicates.")
         return value
 
     def add_selection(self, selection: Selection) -> None:

src/test/test_selections.py

@@ -282,6 +282,15 @@ def test_target_ids_validation(self):
                 target_ids=[123],  # Invalid: not a string
             )
 
+        # Test invalid target_ids (duplicate items)
+        with self.assertRaises(ValueError):
+            SelectionList(
+                selections=[self.s1],
+                timestamp=datetime.now(),
+                # Invalid: due to duplicates
+                target_ids=["CVE-1900-1234","CVE-1900-1234"],
+            )
+
     def test_add_selection_method(self):
         """Test the add_selection method."""
         initial_count = len(self.selections.selections)