fix a bug in csv_analyzer that was assuming target values were always in ascending order.

Author: ahouseholder

src/ssvc/csv_analyzer.py

@@ -326,12 +326,17 @@ def permute_feature_importance(df: pd.DataFrame, target: str) -> pd.DataFrame:
     return imp
 
 
-def check_topological_order(df: pd.DataFrame, target: str) -> list[dict]:
+def check_topological_order(df: pd.DataFrame, target: str, target_value_order: list[str]=None) -> list[dict]:
     # split df into features and target
     X, y = _prepare_data(df, target)
 
-    # convert outcome to numeric codes
-    codes = list(enumerate(y.unique()))
+    if target_value_order is None:
+        # convert outcome to numeric codes
+        codes = list(enumerate(y.unique()))
+    else:
+        # use the provided order for the target values
+        codes = list(enumerate(target_value_order))
+        
     mapper = {v: k for (k, v) in codes}
     y = y.replace(mapper)
 

src/ssvc/decision_tables/base.py

@@ -565,7 +565,9 @@ def check_topological_order(dt: DecisionTable) -> list[dict]:
     logger.debug("Checking topological order of the decision table.")
     df = decision_table_to_shortform_df(dt)
     target = _get_target_column_name(df.columns[-1])
-    return check_topological_order(df, target=target)
+    target_values = dt.decision_points[dt.outcome].values
+    target_value_order = [v.key for v in target_values]
+    return check_topological_order(df, target=target, target_value_order=target_value_order)
 
 
 def main() -> None:

src/ssvc/decision_tables/ssvc/__init__.py

@@ -1,12 +1,22 @@
 #!/usr/bin/env python
 """
-file: __init__.py
-author: adh
-created_at: 7/18/25 12:10 PM
+Provides Decision Tables within the SSVC namespace.
 """
-
- def main():
-    pass
-           
- if __name__ == '__main__':
-    main()
+#  Copyright (c) 2025 Carnegie Mellon University.
+#  NO WARRANTY. THIS CARNEGIE MELLON UNIVERSITY AND SOFTWARE
+#  ENGINEERING INSTITUTE MATERIAL IS FURNISHED ON AN "AS-IS" BASIS.
+#  CARNEGIE MELLON UNIVERSITY MAKES NO WARRANTIES OF ANY KIND,
+#  EITHER EXPRESSED OR IMPLIED, AS TO ANY MATTER INCLUDING, BUT
+#  NOT LIMITED TO, WARRANTY OF FITNESS FOR PURPOSE OR
+#  MERCHANTABILITY, EXCLUSIVITY, OR RESULTS OBTAINED FROM USE
+#  OF THE MATERIAL. CARNEGIE MELLON UNIVERSITY DOES NOT MAKE
+#  ANY WARRANTY OF ANY KIND WITH RESPECT TO FREEDOM FROM
+#  PATENT, TRADEMARK, OR COPYRIGHT INFRINGEMENT.
+#  Licensed under a MIT (SEI)-style license, please see LICENSE or contact
+#  permission@sei.cmu.edu for full terms.
+#  [DISTRIBUTION STATEMENT A] This material has been approved for
+#  public release and unlimited distribution. Please see Copyright notice
+#  for non-US Government use and distribution.
+#  This Software includes and/or makes use of Third-Party Software each
+#  subject to its own license.
+#  DM24-0278