Skip to content

Commit 247758e

Browse files
committed
image_delegate: avoid using default in switch
It is better to enumerate all formats (although a bit more verbose) becasue then the compiler checks if all enum members are handled.
1 parent c35b498 commit 247758e

File tree

1 file changed

+31
-3
lines changed

1 file changed

+31
-3
lines changed

src/utils/image_delegate.c

Lines changed: 31 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -440,9 +440,18 @@ image_load_delegate_t gpujpeg_get_image_load_delegate(enum gpujpeg_image_file_fo
440440
return y4m_load_delegate;
441441
case GPUJPEG_IMAGE_FILE_TST:
442442
return tst_image_load_delegate;
443-
default:
443+
case GPUJPEG_IMAGE_FILE_UNKNOWN:
444+
case GPUJPEG_IMAGE_FILE_JPEG:
445+
case GPUJPEG_IMAGE_FILE_RAW:
446+
case GPUJPEG_IMAGE_FILE_GRAY:
447+
case GPUJPEG_IMAGE_FILE_YUV:
448+
case GPUJPEG_IMAGE_FILE_YUVA:
449+
case GPUJPEG_IMAGE_FILE_I420:
450+
case GPUJPEG_IMAGE_FILE_RGB:
451+
case GPUJPEG_IMAGE_FILE_RGBA:
444452
return NULL;
445453
}
454+
return NULL;
446455
}
447456

448457
image_probe_delegate_t gpujpeg_get_image_probe_delegate(enum gpujpeg_image_file_format format)
@@ -457,9 +466,18 @@ image_probe_delegate_t gpujpeg_get_image_probe_delegate(enum gpujpeg_image_file_
457466
return y4m_probe_delegate;
458467
case GPUJPEG_IMAGE_FILE_TST:
459468
return tst_image_probe_delegate;
460-
default:
469+
case GPUJPEG_IMAGE_FILE_UNKNOWN:
470+
case GPUJPEG_IMAGE_FILE_JPEG:
471+
case GPUJPEG_IMAGE_FILE_RAW:
472+
case GPUJPEG_IMAGE_FILE_GRAY:
473+
case GPUJPEG_IMAGE_FILE_YUV:
474+
case GPUJPEG_IMAGE_FILE_YUVA:
475+
case GPUJPEG_IMAGE_FILE_I420:
476+
case GPUJPEG_IMAGE_FILE_RGB:
477+
case GPUJPEG_IMAGE_FILE_RGBA:
461478
return NULL;
462479
}
480+
return NULL;
463481
}
464482

465483
image_save_delegate_t gpujpeg_get_image_save_delegate(enum gpujpeg_image_file_format format)
@@ -473,9 +491,19 @@ image_save_delegate_t gpujpeg_get_image_save_delegate(enum gpujpeg_image_file_fo
473491
return pnm_save_delegate;
474492
case GPUJPEG_IMAGE_FILE_Y4M:
475493
return y4m_save_delegate;
476-
default:
494+
case GPUJPEG_IMAGE_FILE_UNKNOWN:
495+
case GPUJPEG_IMAGE_FILE_JPEG:
496+
case GPUJPEG_IMAGE_FILE_RAW:
497+
case GPUJPEG_IMAGE_FILE_GRAY:
498+
case GPUJPEG_IMAGE_FILE_YUV:
499+
case GPUJPEG_IMAGE_FILE_YUVA:
500+
case GPUJPEG_IMAGE_FILE_I420:
501+
case GPUJPEG_IMAGE_FILE_RGB:
502+
case GPUJPEG_IMAGE_FILE_RGBA:
503+
case GPUJPEG_IMAGE_FILE_TST:
477504
return NULL;
478505
}
506+
return NULL;
479507
}
480508

481509
/* vi: set expandtab sw=4 : */

0 commit comments

Comments
 (0)