wasapi: fix setting dev by UUID

The mutibyte to wide character conversion was (perhaps since the
beginning) wrong - mbtowc converts just one character - it should have
beem mbstowcs but using rather mbsrttowcs (thread-safe).

Author: MartinPulec

src/audio/capture/wasapi.cpp

@@ -26,14 +26,16 @@
  */
 
 
+#include <assert.h>               // for assert
 #include <audiosessiontypes.h>    // for AUDCLNT_STREAMFLAGS_LOOPBACK, _AUDC...
 #include <audioclient.h>
 #include <basetsd.h>              // for HRESULT, UINT, LPWSTR, GUID, UINT32
 #include <cctype>                 // for isdigit
 #include <cstdio>                 // for mesnprintf
-#include <cstdlib>                // for realloc, atoi, malloc, mbtowc, free
+#include <cstdlib>                // for realloc, atoi, malloc, free
 #include <cstring>                // for NULL, memset, strcmp, strlen, wcslen
 #include <combaseapi.h>           // for CoTaskMemFree, CoCreateInstance
+#include <cwchar>                 // for mbsrtowcs
 #include <guiddef.h>              // for IsEqualGUID
 #include <iomanip>
 #include <iostream>
@@ -248,7 +250,12 @@ static void * audio_cap_wasapi_init(struct module *parent, const char *cfg)
                 } else if (strcmp(cfg, "loopback") == 0) {
                         index = IDX_LOOP;
                 } else {
-                        mbtowc(deviceID, cfg, (sizeof deviceID / 2) - 1);
+                        const char *uuid = cfg;
+                        mbstate_t state{};
+                        mbsrtowcs(deviceID, &uuid,
+                                  (sizeof deviceID / sizeof deviceID[0]) - 1,
+                                  &state);
+                        assert(uuid == NULL);
                 }
         }
         auto s = new state_acap_wasapi();

src/audio/playback/wasapi.cpp

@@ -35,8 +35,9 @@
 #include <cctype>                  // for isdigit
 #include <combaseapi.h>            // for CoTaskMemFree, CoCreateInstance
 #include <cstdio>                  // for snprintf
-#include <cstdlib>                 // for NULL, atoi, malloc, mbtowc, realloc
+#include <cstdlib>                 // for NULL, atoi, malloc, realloc
 #include <cstring>                 // for memset, strcmp, strlen, wcslen
+#include <cwchar>                  // for mbsrtowcs
 #include <iostream>
 #include <ksmedia.h>               // for KSAUDIO_SPEAKER_5POINT1_SURROUND
 #include <mediaobj.h>              // for REFERENCE_TIME
@@ -218,7 +219,12 @@ audio_play_wasapi_init(const struct audio_playback_opts *opts)
                 if (isdigit(opts->cfg[0])) {
                         index = atoi(opts->cfg);
                 } else {
-                        mbtowc(deviceID, opts->cfg, (sizeof deviceID / 2) - 1);
+                        const char *uuid = opts->cfg;
+                        mbstate_t state{};
+                        mbsrtowcs(deviceID, &uuid,
+                                  (sizeof deviceID / sizeof deviceID[0]) - 1,
+                                  &state);
+                        assert(uuid == NULL);
                 }
         }
         auto s = new state_aplay_wasapi();