GH scripts: add -f to curl

to catch 4xx HTTP errors (curls returns 0 otherwise)

Author: MartinPulec

.github/scripts/create_continuous_release.sh

@@ -9,7 +9,9 @@ dir=$(dirname "$0")
 . "$dir/json-common.sh"
 
 sudo apt install jq
-URL=$(curl -S -H "Authorization: token $GITHUB_TOKEN" -X GET "https://api.github.com/repos/$GITHUB_REPOSITORY/releases/tags/continuous" | jq -r '.url')
+URL=$(curl -Sf -H "Authorization: token $GITHUB_TOKEN" -X GET\
+ "https://api.github.com/repos/$GITHUB_REPOSITORY/releases/tags/continuous" |
+ jq -r '.url')
 if [ "$URL" != null ]; then # release exists
         exit 0
 fi

.github/scripts/create_release.sh

@@ -21,7 +21,9 @@ REPL_NL=':a;N;$!ba;s/\n/\\n/g'
 markdown_replaces='s/\\_/\\\\_/g;s/\\\*/\\\\*/g' # escape MD escape sequences
 
 sudo apt install jq
-URL=$(curl -S -H "Authorization: token $GITHUB_TOKEN" -X GET "https://api.github.com/repos/$GITHUB_REPOSITORY/releases/tags/$TAG" | jq -r '.url')
+URL=$(curl -Sf -H "Authorization: token $GITHUB_TOKEN" -X GET\
+ "https://api.github.com/repos/$GITHUB_REPOSITORY/releases/tags/$TAG" |
+  jq -r '.url')
 REQ=PATCH
 if [ "$URL" = null ]; then # release doesn't yet exist
   REQ=POST

.github/scripts/delete-asset.sh

@@ -20,7 +20,7 @@ n=-1; while n=$((n + 1)); [ "$n" -lt "$LEN" ]; do
         fi
         ID=$(jq ".[$n].id" "$JSON")
         JSON2=$(mktemp)
-        STATUS=$(curl -S -H "Authorization: token $GITHUB_TOKEN" -X DELETE \
+        STATUS=$(curl -Sf -H "Authorization: token $GITHUB_TOKEN" -X DELETE \
 "https://api.github.com/repos/$GITHUB_REPOSITORY/releases/assets/$ID" \
 -w '%{http_code}' -o "$JSON2")
         check_errors "$JSON2"

.github/scripts/download-gh-asset.sh

@@ -28,5 +28,5 @@ if [ -n "${GITHUB_TOKEN-}" ]; then
 else
         set --
 fi
-curl -sSL "$@" "$gh_path" -o "$file"
+curl -LSfs "$@" "$gh_path" -o "$file"
 

.github/scripts/environment.sh

@@ -136,7 +136,7 @@ set_ximea_url() {
         # ignore GUID 35adfeed-8e15-4b4d-8364-bd5a65cba5c4 because it is
         # ARM (LTS) with pattern Linux_SP.tgz and since it listed first,
         # it will be downloaded for x86, ARM beta is OK
-        ximea_path=$(curl https://www.ximea.com/software-downloads |
+        ximea_path=$(curl -f https://www.ximea.com/software-downloads |
                 grep -v 35adfeed-8e15-4b4d-8364-bd5a65cba5c4 |
                 sed -n "/$ximea_pattern/"\
 ' { s-^.*\(/getattachment[^"]*\).*$-\1-; p; q; }')

.github/scripts/get-etag.sh

@@ -6,7 +6,7 @@ output=$1
 url=$2
 optional=${3-}
 
-ETAG=$(curl -LI "$url" | grep -i '^etag' | sed 's/.*"\(.*\)".*/\1/')
+ETAG=$(curl -ILf "$url" | grep -i '^etag' | sed 's/.*"\(.*\)".*/\1/')
 if [ "$ETAG" ]; then
         printf '%s=' "$output"
         printf '%s\n' "$ETAG" | sed 's/[^-._A-Za-z0-9]/_/g'

.github/scripts/install-common-deps.sh

@@ -63,7 +63,7 @@ install_aja() {(
 
 install_ews() {
         sudo mkdir -p /usr/local/include
-        sudo curl -LS https://raw.githubusercontent.com/hellerf/\
+        sudo curl -LSf https://raw.githubusercontent.com/hellerf/\
 EmbeddableWebServer/master/EmbeddableWebServer.h -o \
 /usr/local/include/EmbeddableWebServer.h
 }

.github/scripts/macOS/install_others.sh

@@ -19,7 +19,7 @@ fi
 install_ximea() {(
         installer=/private/var/tmp/XIMEA_OSX_SP.dmg
         if [ ! -f $installer ]; then
-                curl -S -L "$XIMEA_DOWNLOAD_URL" -o $installer
+                curl -Sf -L "$XIMEA_DOWNLOAD_URL" -o $installer
         fi
         hdiutil mount $installer
         sudo cp -a /Volumes/XIMEA/m3api.framework \

.github/scripts/upload-asset.sh

@@ -16,7 +16,7 @@ JSON=$(fetch_json\
 UPLOAD_URL=$(jq -r .upload_url "$JSON" | sed "s/{.*}//")
 
 JSON=$(mktemp)
-STATUS=$(curl -S -H "Authorization: token $GITHUB_TOKEN" -H\
+STATUS=$(curl -Sf -H "Authorization: token $GITHUB_TOKEN" -H\
  "Content-Type: $CONTENT_TYPE" -X POST "$UPLOAD_URL?name=$FILENAME&label=$LABEL"\
  -T "$FILE" -w '%{http_code}' -o "$JSON")
 check_errors "$JSON"

.github/workflows/ccpp.yml

@@ -73,7 +73,8 @@ jobs:
         key: cache-ndi-${{ runner.os }}-${{ steps.etags.outputs.ndi }}
     - name: Download NDI
       if: steps.cache-ndi.outputs.cache-hit != 'true'
-      run: curl -L https://downloads.ndi.tv/SDK/NDI_SDK_Linux/Install_NDI_SDK_v6_Linux.tar.gz -o /var/tmp/Install_NDI_SDK_Linux.tar.gz
+      run: "curl -Lf https://downloads.ndi.tv/SDK/NDI_SDK_Linux/\
+       Install_NDI_SDK_v6_Linux.tar.gz -o /var/tmp/Install_NDI_SDK_Linux.tar.gz"
     - name: bootstrap
       run: |
            . .github/scripts/environment.sh
@@ -107,7 +108,9 @@ jobs:
         mkdir aitest-context # empty build context
         docker build -f .github/scripts/Linux/utils/Dockerfile.ubuntu -t aitest-ubuntu aitest-context
         docker build -f .github/scripts/Linux/utils/Dockerfile.arch -t aitest-arch aitest-context
-        curl -LS -O https://raw.githubusercontent.com/AppImage/pkg2appimage/master/appdir-lint.sh -O https://raw.githubusercontent.com/probonopd/AppImages/master/excludelist
+        curl -LSf -O https://raw.githubusercontent.com/AppImage/pkg2appimage/\
+        master/appdir-lint.sh -O https://raw.githubusercontent.com/probonopd/\
+        AppImages/master/excludelist
         sudo apt install desktop-file-utils libfile-mimeinfo-perl # desktop-file-validate, mimetype
         ./UltraGrid-$VERSION-x86_64.AppImage --appimage-extract
         docker run --rm -v $PWD/squashfs-root/:/AppImage aitest-ubuntu /AppImage/AppRun -v
@@ -181,7 +184,7 @@ jobs:
         key: cache-ximea-${{ matrix.os }}-${{ steps.etags.outputs.ximea }}
     - name: Download XIMEA
       if: steps.cache-macos-ximea.outputs.cache-hit != 'true'
-      run: curl -S -L "$XIMEA_DOWNLOAD_URL" -o /private/var/tmp/XIMEA_OSX_SP.dmg
+      run: curl -LSf "$XIMEA_DOWNLOAD_URL" -o /private/var/tmp/XIMEA_OSX_SP.dmg
     - name: Run actions/cache for NDI
       id: cache-ndi
       uses: actions/cache@main
@@ -190,7 +193,8 @@ jobs:
         key: cache-ndi-${{ runner.os }}-${{ steps.etags.outputs.ndi }}
     - name: Download NDI
       if: steps.cache-ndi.outputs.cache-hit != 'true'
-      run: curl -L https://downloads.ndi.tv/SDK/NDI_SDK_Mac/Install_NDI_SDK_v6_Apple.pkg -o /private/var/tmp/Install_NDI_SDK_Apple.pkg
+      run: "curl -Lf https://downloads.ndi.tv/SDK/NDI_SDK_Mac/Install_\
+       NDI_SDK_v6_Apple.pkg -o /private/var/tmp/Install_NDI_SDK_Apple.pkg"
     - name: bootstrap
       run: .github/scripts/macOS/prepare.sh
     - name: configure
@@ -265,7 +269,8 @@ jobs:
         key: cache-ndi-${{ runner.os }}-${{ steps.etags.outputs.ndi }}
     - name: Download NDI
       if: steps.cache-ndi.outputs.cache-hit != 'true'
-      run: curl 'https://downloads.ndi.tv/SDK/NDI_SDK/NDI%206%20SDK.exe' -o 'C:\ndi.exe'
+      run: curl -f 'https://downloads.ndi.tv/SDK/NDI_SDK/NDI%206%20SDK.exe'
+       -o 'C:\ndi.exe'
     - name: Cache XIMEA
       id: cache-macos-ximea
       uses: actions/cache@main
@@ -274,7 +279,7 @@ jobs:
         key: cache-ximea-${{ runner.os }}-${{ steps.etags.outputs.ximea }}
     - name: Download XIMEA
       if: steps.cache-macos-ximea.outputs.cache-hit != 'true'
-      run: curl "$XIMEA_DOWNLOAD_URL" -o 'C:\XIMEA_API_Installer.exe'
+      run: curl -f "$XIMEA_DOWNLOAD_URL" -o 'C:\XIMEA_API_Installer.exe'
 
     - name: Run actions/cache for libajantv2 build
       id: cache-aja