GH scripts: import back from GPUJPEG

import improvements from GPUJPEG - summary:
- LABEL - replace ' ' with %20 (will get to URL)
- use while instead of for..seq
- cat json file directly (avoid interpretting \n and \r that XSI-compilant
echo, as in dash, does)
- cat really the $json file, don't print its name
- wrap long lines + early return in while-loop

The rewrite of `for n in \`seq` may be perhaps a bit controversal
(with while is less readable) but technically POSIX doesn't specify the
seq comand.

Author: MartinPulec

.github/scripts/delete-asset.sh

@@ -6,21 +6,26 @@ DIR=$(dirname "$0")
 
 TAG_NAME=${1?}
 PATTERN=$(basename "${2?}")
-JSON=$(fetch_json "https://api.github.com/repos/$GITHUB_REPOSITORY/releases/tags/$TAG_NAME" "$GITHUB_TOKEN")
+JSON=$(fetch_json "https://api.github.com/repos/$GITHUB_REPOSITORY/releases/\
+tags/$TAG_NAME" "$GITHUB_TOKEN")
 RELEASE_ID=$(jq -r '.id' "$JSON")
 rm "$JSON"
-JSON=$(fetch_json "https://api.github.com/repos/$GITHUB_REPOSITORY/releases/$RELEASE_ID/assets" "$GITHUB_TOKEN" array)
+JSON=$(fetch_json "https://api.github.com/repos/$GITHUB_REPOSITORY/releases/\
+$RELEASE_ID/assets" "$GITHUB_TOKEN" array)
 LEN=$(jq length "$JSON")
-for n in $(seq 0 $((LEN-1))); do
+n=-1; while n=$((n + 1)); [ "$n" -lt "$LEN" ]; do
         NAME=$(jq -r ".[$n].name" "$JSON")
-        if expr "$NAME" : "$PATTERN$"; then
-                ID=$(jq ".[$n].id" "$JSON")
-                JSON2=$(mktemp)
-                STATUS=$(curl -S -H "Authorization: token $GITHUB_TOKEN" -X DELETE "https://api.github.com/repos/$GITHUB_REPOSITORY/releases/assets/$ID" -w '%{http_code}' -o "$JSON2")
-                check_errors "$JSON2"
-                check_status "$STATUS"
-                rm "$JSON2"
+        if ! expr "$NAME" : "$PATTERN$"; then
+                continue
         fi
+        ID=$(jq ".[$n].id" "$JSON")
+        JSON2=$(mktemp)
+        STATUS=$(curl -S -H "Authorization: token $GITHUB_TOKEN" -X DELETE \
+"https://api.github.com/repos/$GITHUB_REPOSITORY/releases/assets/$ID" \
+-w '%{http_code}' -o "$JSON2")
+        check_errors "$JSON2"
+        check_status "$STATUS"
+        rm "$JSON2"
 done
 rm "$JSON"
 

.github/scripts/json-common.sh

@@ -18,13 +18,13 @@ check_type() {
         TYPE=$(jq -r type "$1")
         if [ "$TYPE" != "$2" ]; then
                 echo "Wrong JSON type - expected $2, got $TYPE" >&2
-                json=$(cat "$1")
-                echo "JSON: $json" >&2
+                echo 'JSON:' >&2
+                cat "$1" >&2
                 exit 1
         fi
 }
 
-## @brief Returns json for given URL and authorization token while checking errors
+## @brief Returns json file for given URL and authorization token while checking errors
 ## @param $1 URL
 ## @param $2 GITHUB_TOKEN (optional)
 ## @param $3 requested type (optional)
@@ -41,7 +41,8 @@ fetch_json() {
         status=$(curl -sS "$@" -X GET "$url" -w "%{http_code}" -o "$json")
         if ! is_int "$status" || [ "$status" -ne 200 ]; then
                 echo "HTTP error code $status" >&2
-                echo "JSON: $json" >&2
+                echo "JSON:" >&2
+                cat "$json" >&2
         fi
         check_errors "$json"
         if [ -n "$req_type" ]; then
@@ -57,8 +58,8 @@ check_status() {
         if ! is_int "$1" || [ "$1" -lt 200 ] || [ "$1" -ge 300 ]; then
                 echo "Wrong response status $1!" >&2
                 if [ -n "${2-}" ]; then
-                        json=$(cat "$2")
-                        echo "JSON: $json" >&2
+                        echo "JSON:" >&2
+                        cat "$2"
                 fi
                 exit 1
         fi

.github/scripts/upload-asset.sh

@@ -8,13 +8,17 @@ TAG_NAME=${1?}
 FILE=${2?}
 FILENAME=$(basename "${2?}")
 CONTENT_TYPE=${3?}
-LABEL=${4?}
+LABEL=$(echo "${4?}" | sed 's/ /%20/g')
 
-JSON=$(fetch_json "https://api.github.com/repos/$GITHUB_REPOSITORY/releases/tags/$TAG_NAME" "$GITHUB_TOKEN")
+JSON=$(fetch_json\
+ "https://api.github.com/repos/$GITHUB_REPOSITORY/releases/tags/$TAG_NAME"\
+ "$GITHUB_TOKEN")
 UPLOAD_URL=$(jq -r .upload_url "$JSON" | sed "s/{.*}//")
 
 JSON=$(mktemp)
-STATUS=$(curl -S -H "Authorization: token $GITHUB_TOKEN" -H "Content-Type: $CONTENT_TYPE" -X POST "$UPLOAD_URL?name=$FILENAME&label=$LABEL" -T "$FILE" -w '%{http_code}' -o "$JSON")
+STATUS=$(curl -S -H "Authorization: token $GITHUB_TOKEN" -H\
+ "Content-Type: $CONTENT_TYPE" -X POST "$UPLOAD_URL?name=$FILENAME&label=$LABEL"\
+ -T "$FILE" -w '%{http_code}' -o "$JSON")
 check_errors "$JSON"
 check_status "$STATUS"
 rm "$JSON"