Skip to content

Commit 40f7bb7

Browse files
committed
CI (all workflows): rename cache check/fetch step
Instead of use "Cache XY" use more techical "Run action/cache for XY" (similarly as implicit name when "name" key was not used). Although the action is really actions/cache, the problem with the previous name is that it actually doesn't cache the named item. It checks, and if found loads, the item. But even if the item is not found, the action reports success in GH web UI, which is quite misleading. So using rather neutral name for the step should slightly decrease the confusion.
1 parent a4c1268 commit 40f7bb7

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

.github/workflows/arm-build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
id: etags
4141
run: |
4242
echo "ndi=$($GITHUB_WORKSPACE/.github/scripts/get-etags.sh https://downloads.ndi.tv/SDK/NDI_SDK_Linux/Install_NDI_SDK_v5_Linux.tar.gz)" >> $GITHUB_OUTPUT
43-
- name: Cache NDI
43+
- name: Run actions/cache for NDI
4444
id: cache-ndi
4545
uses: actions/cache@main
4646
with:
@@ -50,7 +50,7 @@ jobs:
5050
if: steps.cache-ndi.outputs.cache-hit != 'true'
5151
run: curl -L https://downloads.ndi.tv/SDK/NDI_SDK_Linux/Install_NDI_SDK_v5_Linux.tar.gz -o /var/tmp/Install_NDI_SDK_Linux.tar.gz
5252

53-
- name: Cache Environment
53+
- name: Run actions/cache for ARM Chroot
5454
id: cache-bootstrap
5555
uses: actions/cache@main
5656
with:
@@ -71,7 +71,7 @@ jobs:
7171
sudo cp /usr/bin/qemu-${{ matrix.qemu_bin_arch }}-static ~/chroot/usr/bin/
7272
sudo chroot ~/chroot /.github/scripts/Linux/arm/bootstrap.sh ${{ matrix.arch }}
7373
cd ~ && sudo tar cf chroot.tar chroot # Create archive for caching. Needs to be created as root, therefore created manually.
74-
- name: Extract Cached Environment
74+
- name: Extract Cached Chroot
7575
if: steps.cache-bootstrap.outputs.cache-hit == 'true'
7676
run: |
7777
cd ~

.github/workflows/ccpp.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
id: etags
6464
run: |
6565
echo "ndi=$($GITHUB_WORKSPACE/.github/scripts/get-etags.sh https://downloads.ndi.tv/SDK/NDI_SDK_Linux/Install_NDI_SDK_v6_Linux.tar.gz)" >> $GITHUB_OUTPUT
66-
- name: Cache NDI
66+
- name: Run actions/cache for NDI
6767
id: cache-ndi
6868
uses: actions/cache@main
6969
with:
@@ -76,7 +76,7 @@ jobs:
7676
run: |
7777
. .github/scripts/environment.sh
7878
.github/scripts/Linux/prepare.sh
79-
- name: Cache FFmpeg
79+
- name: Run actions/cache for FFmpeg
8080
id: cache-ffmpeg
8181
uses: actions/cache@main
8282
with:
@@ -154,7 +154,7 @@ jobs:
154154
echo "ximea=$($GITHUB_WORKSPACE/.github/scripts/get-etags.sh https://www.ximea.com/downloads/recent/XIMEA_OSX_SP.dmg)" >> $GITHUB_OUTPUT
155155
- name: Set environment
156156
run: . .github/scripts/environment.sh
157-
- name: Cache Non-Free SDKs
157+
- name: Run actions/cache for Non-Free SDKs
158158
id: cache-macos-nonfree-sdks
159159
uses: actions/cache@main
160160
with:
@@ -167,7 +167,7 @@ jobs:
167167
mkdir -p ${{ env.SDK_NONFREE_PATH }}
168168
cd ${{ env.SDK_NONFREE_PATH }}
169169
curl -S -f -O "$SDK_URL/$DELTA_MAC_ARCHIVE" || true
170-
- name: Cache XIMEA
170+
- name: Run actions/cache for XIMEA
171171
id: cache-macos-ximea
172172
uses: actions/cache@main
173173
with:
@@ -176,7 +176,7 @@ jobs:
176176
- name: Download XIMEA
177177
if: steps.cache-macos-ximea.outputs.cache-hit != 'true'
178178
run: curl -S -L https://www.ximea.com/downloads/recent/XIMEA_OSX_SP.dmg -o /private/var/tmp/XIMEA_OSX_SP.dmg
179-
- name: Cache NDI
179+
- name: Run actions/cache for NDI
180180
id: cache-ndi
181181
uses: actions/cache@main
182182
with:
@@ -248,7 +248,7 @@ jobs:
248248
- name: Find MSVC
249249
run: .github/scripts/Windows/find_msvc.ps1
250250
shell: pwsh -command ". '{0}'"
251-
- name: Cache NDI
251+
- name: Run actions/cache for NDI
252252
id: cache-ndi
253253
uses: actions/cache@main
254254
with:
@@ -267,7 +267,7 @@ jobs:
267267
if: steps.cache-macos-ximea.outputs.cache-hit != 'true'
268268
run: curl 'https://www.ximea.com/support/attachments/download/37/XIMEA_API_Installer.exe' -o 'C:\XIMEA_API_Installer.exe'
269269

270-
- name: Cache libajantv2 build
270+
- name: Run actions/cache for libajantv2 build
271271
id: cache-aja
272272
uses: actions/cache@main
273273
with:
@@ -283,7 +283,7 @@ jobs:
283283
- name: bootsrap
284284
run: .github/scripts/Windows/prepare.ps1
285285
shell: pwsh -command ". '{0}'"
286-
- name: Cache JACK
286+
- name: Run actions/cache for JACK
287287
id: cache-jack
288288
uses: actions/cache@main
289289
with:
@@ -296,7 +296,7 @@ jobs:
296296
- name: bootsrap MSYS2
297297
run: $GITHUB_WORKSPACE/.github/scripts/Windows/prepare_msys.sh
298298

299-
- name: Cache Spout build
299+
- name: Run actions/cache for Spout build
300300
id: cache-spout
301301
uses: actions/cache@main
302302
with:
@@ -308,7 +308,7 @@ jobs:
308308
- name: Install Spout
309309
run: $GITHUB_WORKSPACE/.github/scripts/Windows/install_spout.sh install
310310

311-
- name: Cache CineForm build
311+
- name: Run actions/cache for CineForm build
312312
id: cache-cineform
313313
uses: actions/cache@main
314314
with:

.github/workflows/coverity-scan.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
run: |
2323
FILENAME=$(curl -LI "https://scan.coverity.com/download/linux64?token=$coverity_token&project=UltraGrid" | sed -n '/content-disposition/s/.*\"\(.*\)\"/\1/p')
2424
echo "filename=$FILENAME" >> $GITHUB_OUTPUT
25-
- name: Cache Coverity build tool
25+
- name: Run actions/cache for Coverity build tool
2626
if: ${{ env.coverity_token }}
2727
id: cache-coverity-tool
2828
uses: actions/cache@main
@@ -47,7 +47,7 @@ jobs:
4747
id: etags
4848
run: |
4949
echo "ndi=$($GITHUB_WORKSPACE/.github/scripts/get-etags.sh https://downloads.ndi.tv/SDK/NDI_SDK_Linux/Install_NDI_SDK_v6_Linux.tar.gz)" >> $GITHUB_OUTPUT
50-
- name: Cache NDI
50+
- name: Run actions/cache for NDI
5151
if: ${{ env.coverity_token }}
5252
id: cache-ndi
5353
uses: actions/cache@main

0 commit comments

Comments
 (0)