download-gh-asset.sh improved

fix the situation when most recent release doesn't include the asset
matching the patern (but some other does)

notes:
- the assets are included directly in /releases, no need for subsequent fetch
- use -e to fail jq if the result is null
- $pattern doesn't need to be anchored

Author: MartinPulec

.github/scripts/download-gh-asset.sh

@@ -15,12 +15,14 @@ readonly file="${3?output filename must be given!}"
 
 gh_release_json=$(fetch_json "https://api.github.com/repos/$repo/releases" \
         "${GITHUB_TOKEN-}" array)
-gh_release=$(jq -r '.[0].assets_url' "$gh_release_json")
+gh_path=$(jq  -e -r '
+[ .[]                                    # for each top‐level object
+  | .assets[]                            # walk into its assets array
+  | select(.name | test("'"$pattern"'")) # keep only those whose name matches
+  | .browser_download_url                # print just the URL
+][0]                                     # include only 1st match
+' "$gh_release_json")
 rm -- "$gh_release_json"
-gh_path_json=$(fetch_json "$gh_release" "${GITHUB_TOKEN-}" array)
-gh_path=$(jq -r '[.[] | select(.name | test(".*'"$pattern"'.*"))] |
-        .[0].browser_download_url' "$gh_path_json")
-rm -- "$gh_path_json"
 if [ -n "${GITHUB_TOKEN-}" ]; then
         set -- -H "Authorization: token $GITHUB_TOKEN"
 else