vdisp/gl: fix CID 481468

MartinPulec · MartinPulec · commit 6f0711274406 · 2025-06-18T10:50:52.000+02:00
a null-pointer dereference if "fullhelp" isn't first option
diff --git a/src/video_display/gl.cpp b/src/video_display/gl.cpp
@@ -715,7 +715,7 @@ static void *display_gl_parse_fmt(struct state_gl *s, char *ptr) {
 
         while((tok = strtok_r(ptr, ":", &save_ptr)) != NULL) {
                 if (strcmp(tok, "help") == 0 || strcmp(tok, "fullhelp") == 0) {
-                        gl_show_help(strcmp(ptr, "fullhelp") == 0);
+                        gl_show_help(strcmp(tok, "fullhelp") == 0);
                         return INIT_NOERR;
                 }
                 if (!strcmp(tok, "d") || !strcmp(tok, "dforce")) {

Original file line number	Diff line number	Diff line change
`@@ -715,7 +715,7 @@ static void display_gl_parse_fmt(struct state_gl s, char *ptr) {`
`715`	`715`
`716`	`716`	`while((tok = strtok_r(ptr, ":", &save_ptr)) != NULL) {`
`717`	`717`	`if (strcmp(tok, "help") == 0 \|\| strcmp(tok, "fullhelp") == 0) {`
`718`		`- gl_show_help(strcmp(ptr, "fullhelp") == 0);`
	`718`	`+ gl_show_help(strcmp(tok, "fullhelp") == 0);`
`719`	`719`	`return INIT_NOERR;`
`720`	`720`	`}`
`721`	`721`	`if (!strcmp(tok, "d") \|\| !strcmp(tok, "dforce")) {`