jpeg_reader spiff: fix skipping invalid dir marker

MartinPulec · MartinPulec · commit 7bf010a36b95 · 2025-11-19T08:14:43.000+01:00
fixes CID 897314
diff --git a/src/utils/jpeg_reader.c b/src/utils/jpeg_reader.c
@@ -721,7 +721,7 @@ read_spiff_directory(uint8_t** image, struct jpeg_reader *reader, int length)
 {
     if ( length < 8 ) { // ELEN at least 8
         MSG(ERROR, "APP8 SPIFF directory too short (%d bytes)\n", length);
-        image += length - 2;
+        *image += length - 2;
         return -1;
     }
     uint32_t tag = read_4byte(*image);

Original file line number	Diff line number	Diff line change
`@@ -721,7 +721,7 @@ read_spiff_directory(uint8_t** image, struct jpeg_reader *reader, int length)`
`721`	`721`	`{`
`722`	`722`	`if ( length < 8 ) { // ELEN at least 8`
`723`	`723`	`MSG(ERROR, "APP8 SPIFF directory too short (%d bytes)\n", length);`
`724`		`- image += length - 2;`
	`724`	`+ *image += length - 2;`
`725`	`725`	`return -1;`
`726`	`726`	`}`
`727`	`727`	`uint32_t tag = read_4byte(*image);`