vcap/decklink: fix CID 470422

MartinPulec · MartinPulec · commit 7e43ab81d2bd · 2024-11-26T08:29:30.000+01:00
fmt cannot be nullptr
diff --git a/src/video_capture/decklink.cpp b/src/video_capture/decklink.cpp
@@ -824,7 +824,7 @@ settings_init(struct vidcap_decklink_state *s, char *fmt)
         char *tmp;
         char *save_ptr = NULL;
 
-        if (!fmt || (tmp = strtok_r(fmt, ":", &save_ptr)) == NULL) {
+        if ((tmp = strtok_r(fmt, ":", &save_ptr)) == NULL) {
                 MSG(INFO, "Auto-choosen device 0.\n");
                 return true;
         }

Original file line number	Diff line number	Diff line change
`@@ -824,7 +824,7 @@ settings_init(struct vidcap_decklink_state s, char fmt)`
`824`	`824`	`char *tmp;`
`825`	`825`	`char *save_ptr = NULL;`
`826`	`826`
`827`		`- if (!fmt \|\| (tmp = strtok_r(fmt, ":", &save_ptr)) == NULL) {`
	`827`	`+ if ((tmp = strtok_r(fmt, ":", &save_ptr)) == NULL) {`
`828`	`828`	`MSG(INFO, "Auto-choosen device 0.\n");`
`829`	`829`	`return true;`
`830`	`830`	`}`