fs: get_data_path: fix inverted cond + rename

fixed inverted condition

rename to get_ug_data_path

Author: MartinPulec

src/audio/capture/fluidsynth.c

@@ -184,7 +184,8 @@ get_soundfont()
                 return strdup(env_fs);
         }
         char bundled[MAX_PATH_SIZE];
-        snprintf_ch(bundled, "%s/%s", get_data_path(), "TimGM6mb_but_fixed__piano_.sf3");
+        snprintf_ch(bundled, "%s/%s", get_ug_data_path(),
+                    "TimGM6mb_but_fixed__piano_.sf3");
         const char *sf_candidates[] = {
                 "/usr/share/soundfonts/default.sf2",
                 "/usr/share/soundfonts/default.sf3",

src/utils/fs.c

@@ -217,7 +217,7 @@ file_exists(const char *path, enum check_file_type type)
  * @retval the path; NULL if not found
  */
 const char *
-get_data_path()
+get_ug_data_path()
 {
         static __thread char path[MAX_PATH_SIZE];
         if (strlen(path) > 0) { // already set
@@ -239,7 +239,7 @@ get_data_path()
         }
 
         snprintf_ch(path, SRCDIR "%s", suffix);
-        if (!file_exists(path, FT_DIRECTORY)) {
+        if (file_exists(path, FT_DIRECTORY)) {
                 MSG(VERBOSE, "Using data path %s\n", path);
                 return path;
         }

src/utils/fs.h

@@ -68,7 +68,7 @@ enum check_file_type {
 bool file_exists(const char *path, enum check_file_type type);
 const char *get_temp_dir(void);
 FILE *get_temp_file(const char **filename);
-const char *get_data_path(void);
+const char *get_ug_data_path(void);
 char *strdup_path_with_expansion(const char *orig_path);
 
 #ifdef __cplusplus

src/video_display/vulkan/vulkan_display.cpp

@@ -660,7 +660,7 @@ get_shader_path()
         constexpr char suffix[] = "/vulkan_shaders";
         // note that get_install_root returns bin/.. if run from build,
         // which will not contain the shaders for out-of-tree builds
-        const char *data_path = get_data_path();
+        const char *data_path = get_ug_data_path();
         if (data_path != nullptr) {
                 std::string path_to_shaders = std::string(data_path) + suffix;
                 std::filesystem::directory_entry dir{ std::filesystem::path(