Revert "vdisp,vcap/decklink: do not fail if insuff drv ver"

Since the following error, the hard fail is again desirable. It, however
doesn't fail if the driver is usable (not so old, using same ABI).

This reverts commit cac114d.

Author: MartinPulec

src/video_capture/decklink.cpp

@@ -1426,8 +1426,6 @@ vidcap_decklink_init(struct vidcap_params *params, void **state)
 {
         const char *fmt = vidcap_params_get_fmt(params);
 
-        blackmagic_api_version_check();
-
         if (strcmp(fmt, "help") == 0 || strcmp(fmt, "fullhelp") == 0) {
                 decklink_help(strcmp(fmt, "fullhelp") == 0);
                 return VIDCAP_INIT_NOERR;
@@ -1461,6 +1459,11 @@ vidcap_decklink_init(struct vidcap_params *params, void **state)
 		return VIDCAP_INIT_FAIL;
 	}
 
+        if (!blackmagic_api_version_check()) {
+                delete s;
+                return VIDCAP_INIT_FAIL;
+        }
+
         switch (get_bits_per_component(s->codec)) {
         case 0: s->requested_bit_depth = 0; break;
         case 8: s->requested_bit_depth = bmdDetectedVideoInput8BitDepth; break;

src/video_display/decklink.cpp

@@ -1416,8 +1416,6 @@ static void *display_decklink_init(struct module *parent, const char *fmt, unsig
         IDeckLinkConfiguration*         deckLinkConfiguration = NULL;
         // for Decklink Studio which has switchable XLR - analog 3 and 4 or AES/EBU 3,4 and 5,6
 
-        blackmagic_api_version_check();
-
         if (strcmp(fmt, "help") == 0 || strcmp(fmt, "fullhelp") == 0) {
                 show_help(strcmp(fmt, "fullhelp") == 0);
                 return INIT_NOERR;
@@ -1446,6 +1444,11 @@ static void *display_decklink_init(struct module *parent, const char *fmt, unsig
                 return NULL;
         }
 
+        if (!blackmagic_api_version_check()) {
+                delete s;
+                return NULL;
+        }
+
         // Connect to the first DeckLink instance
         for (auto &d : bmd_get_sorted_devices(&s->com_initialized, true)) {
                 s->deckLink = get<0>(d).release(); // unmanage