debug: move some stuff to utils/debug

The rationale is to separate the config.h-dependent stuff to a separate
file to eliminate the need to transitively include config.h.

+ fix the files that need config.h directly to include it

Author: MartinPulec

src/audio/audio.cpp

@@ -70,6 +70,7 @@
 #include "audio/playback/sdi.h"
 #include "audio/resampler.hpp"
 #include "audio/utils.h"
+#include "config.h"                     // for HAVE_SPEEXDSP
 #include "debug.h"
 #include "host.h"
 #include "module.h"

src/audio/playback/jack.c

@@ -43,6 +43,7 @@
 #include "audio/audio_playback.h"
 #include "audio/types.h"
 #include "audio/utils.h"
+#include "config.h"                // for PACKAGE_NAME
 #include "debug.h"
 #include "host.h"
 #include "jack_common.h"

src/blackmagic_common.cpp

@@ -65,6 +65,7 @@
 #include "host.h"
 #include "tv.h"
 #include "utils/color_out.h"
+#include "utils/debug.h"         // for DEBUG_TIMER_*
 #include "utils/macros.h"
 #include "utils/windows.h"
 #include "utils/worker.h"

src/capture_filter/resize_utils.cpp

@@ -64,6 +64,7 @@
 #include "capture_filter/resize_utils.h"
 #include "debug.h"
 #include "utils/color_out.h"
+#include "utils/debug.h"                 // for DEBUG_TIMER_*
 #include "video.h"
 
 #define DEFAULT_ALGO INTER_LINEAR

src/debug.cpp

@@ -39,6 +39,9 @@
  * SUCH DAMAGE.
  */
 
+#include "debug.h"
+#include "utils/debug.h"
+
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif // defined HAVE_CONFIG_H
@@ -52,7 +55,6 @@
 #include <string_view>
 #include <unordered_map>
 
-#include "debug.h"
 #include "host.h"
 #include "utils/color_out.h"
 #include "utils/string_view_utils.hpp"

src/debug.h

@@ -47,9 +47,6 @@
 #include <stdio.h> // FILE
 #endif // defined __cplusplus
 
-#ifdef HAVE_CONFIG_H
-#include "config.h" // DEBUG
-#endif // defined HAVE_CONFIG_H
 #include "tv.h"
 
 #define UNUSED(x)	(x=x)
@@ -80,11 +77,6 @@ extern "C" {
 #endif
 
 void debug_dump(const void*lp, int len);
-#ifdef DEBUG
-void debug_file_dump(const char *key, void (*serialize)(const void *data, FILE *), void *data);
-#else
-#define debug_file_dump(key, serialize, data) (void) (key), (void) (serialize), (void) (data)
-#endif
 
 #define error_msg(...) log_msg(LOG_LEVEL_ERROR, __VA_ARGS__)
 #define verbose_msg(...) log_msg(LOG_LEVEL_VERBOSE, __VA_ARGS__)
@@ -323,13 +315,4 @@ if ((level) <= log_level) Logger(level).Get()
 
 #endif
 
-#ifdef DEBUG
-#define DEBUG_TIMER_EVENT(name) time_ns_t name = get_time_in_ns()
-#define DEBUG_TIMER_START(name) DEBUG_TIMER_EVENT(name##_start);
-#define DEBUG_TIMER_STOP(name) DEBUG_TIMER_EVENT(name##_stop); log_msg(LOG_LEVEL_DEBUG2, "%s duration: %lf s\n", #name, (name##_stop - name##_start) / NS_IN_SEC_DBL) // NOLINT(cppcoreguidelines-pro-type-vararg, hicpp-vararg)
-#else
-#define DEBUG_TIMER_START(name)
-#define DEBUG_TIMER_STOP(name)
-#endif
-
 #endif

src/hwaccel_vdpau.h

@@ -45,6 +45,8 @@
 #ifndef HWACCEL_VDPAU_H
 #define HWACCEL_VDPAU_H
 
+#include "config.h"         // for HWACC_VDPAU
+
 #ifdef HWACC_VDPAU
 
 #include "hwaccel_libav_common.h"

src/libavcodec/from_lavc_vid_conv.c

@@ -55,6 +55,7 @@
 
 #include "color.h"
 #include "compat/qsort_s.h"
+#include "config.h"       // for HWACC_VDPAU
 #include "debug.h"
 #include "host.h"
 #include "hwaccel_vdpau.h"
@@ -64,6 +65,7 @@
 #include "libavcodec/lavc_common.h"
 #include "pixfmt_conv.h"
 #include "types.h"
+#include "utils/debug.h"  // for DEBUG_TIMER_*
 #include "utils/macros.h" // OPTIMIZED_FOR
 #include "utils/misc.h"   // get_cpu_core_count
 #include "utils/worker.h" // task_run_parallel

src/libavcodec/lavc_video.c

@@ -44,6 +44,7 @@
  * Some conversions to RGBA ignore RGB-shifts - either fix that or deprecate RGB-shifts
  */
 
+#include "config.h" // for HAVE_SWSCALE
 #include "debug.h"
 #include "lib_common.h"
 #include "libavcodec/lavc_common.h"

src/libavcodec/lavc_video.h

@@ -44,6 +44,7 @@
 #include <stdio.h>
 #endif
 
+#include "config.h"  // for HAVE_SWSCALE
 #include "libavcodec/lavc_common.h"
 
 #ifdef __cplusplus