rtp/video_decoders: fixed a leak

MartinPulec · MartinPulec · commit ba38f4b86e27 · 2025-04-14T15:44:12.000+02:00
Fix leaked frame when decode failed - this is a dumb regression introduced with the commit b52bf7b (2024-09-23) by inverting the condition. also CID 152946
diff --git a/src/rtp/video_decoders.cpp b/src/rtp/video_decoders.cpp
@@ -1847,7 +1847,7 @@ int decode_video_frame(struct coded_data *cdata, void *decoder_data, struct pbuf
         }
 cleanup:
         ;
-        if (ret) {
+        if (!ret) {
                 vf_free(frame);
         }
         pbuf_data->decoded++;

Original file line number	Diff line number	Diff line change
`@@ -1847,7 +1847,7 @@ int decode_video_frame(struct coded_data cdata, void decoder_data, struct pbuf`
`1847`	`1847`	`}`
`1848`	`1848`	`cleanup:`
`1849`	`1849`	`;`
`1850`		`- if (ret) {`
	`1850`	`+ if (!ret) {`
`1851`	`1851`	`vf_free(frame);`
`1852`	`1852`	`}`
`1853`	`1853`	`pbuf_data->decoded++;`