Merge branch 'combinators' into 'main'

WIF - Combinators - Throw std::runtime_error in combine() when the input vector is empty

See merge request feta/wif-group/libwif!47

Author: plnyrich

src/wif/combinators/averageCombinator.cpp

@@ -10,13 +10,18 @@
 #include "wif/combinators/averageCombinator.hpp"
 
 #include <numeric>
+#include <stdexcept>
 
 namespace WIF {
 
 double AverageCombinator::combine(const std::vector<double>& valuesToCombine)
 {
+	if (valuesToCombine.empty()) {
+		throw std::runtime_error("Nothing to combine! The supplied vector is empty.");
+	}
+
 	double valuesSum = std::accumulate(valuesToCombine.begin(), valuesToCombine.end(), 0.0);
-	return valuesToCombine.size() ? valuesSum / valuesToCombine.size() : 0;
+	return valuesSum / valuesToCombine.size();
 }
 
 } // namespace WIF

src/wif/combinators/binaryDSTCombinator.cpp

@@ -8,12 +8,14 @@
 
 #include "wif/combinators/binaryDSTCombinator.hpp"
 
+#include <stdexcept>
+
 namespace WIF {
 
 double BinaryDSTCombinator::combine(const std::vector<double>& valuesToCombine)
 {
-	if (valuesToCombine.size() == 0) {
-		return 0.0;
+	if (valuesToCombine.empty()) {
+		throw std::runtime_error("Nothing to combine! The supplied vector is empty.");
 	}
 
 	constexpr size_t POSITIVE_HYPOTHESIS = 0xAA;

src/wif/combinators/sumCombinator.cpp

@@ -10,11 +10,16 @@
 #include "wif/combinators/sumCombinator.hpp"
 
 #include <numeric>
+#include <stdexcept>
 
 namespace WIF {
 
 double SumCombinator::combine(const std::vector<double>& valuesToCombine)
 {
+	if (valuesToCombine.empty()) {
+		throw std::runtime_error("Nothing to combine! The supplied vector is empty.");
+	}
+
 	return std::accumulate(valuesToCombine.begin(), valuesToCombine.end(), 0.0);
 }