Merge pull request #165 from BonnyAD9/icmp-plugin

SiskaPavel · web-flow · commit 078207e3a101 · 2023-08-01T15:35:19.000+02:00
icmp: fix byte order
diff --git a/process/icmp.hpp b/process/icmp.hpp
@@ -83,7 +83,7 @@ struct RecordExtICMP : public RecordExt {
 #ifdef WITH_NEMEA
    virtual void fill_unirec(ur_template_t *tmplt, void *record)
    {
-      ur_set(tmplt, record, F_L4_ICMP_TYPE_CODE, type_code);
+      ur_set(tmplt, record, F_L4_ICMP_TYPE_CODE, ntohs(type_code));
    }
 
    const char *get_unirec_tmplt() const
@@ -100,7 +100,7 @@ struct RecordExtICMP : public RecordExt {
          return -1;
       }
 
-      *reinterpret_cast<uint16_t *>(buffer) = ntohs(type_code);
+      *reinterpret_cast<uint16_t *>(buffer) = type_code;
 
       return LEN;
    }

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ struct RecordExtICMP : public RecordExt {`
`83`	`83`	`#ifdef WITH_NEMEA`
`84`	`84`	`virtual void fill_unirec(ur_template_t tmplt, void record)`
`85`	`85`	`{`
`86`		`- ur_set(tmplt, record, F_L4_ICMP_TYPE_CODE, type_code);`
	`86`	`+ ur_set(tmplt, record, F_L4_ICMP_TYPE_CODE, ntohs(type_code));`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`const char *get_unirec_tmplt() const`
`@@ -100,7 +100,7 @@ struct RecordExtICMP : public RecordExt {`
`100`	`100`	`return -1;`
`101`	`101`	`}`
`102`	`102`
`103`		`- reinterpret_cast<uint16_t >(buffer) = ntohs(type_code);`
	`103`	`+ reinterpret_cast<uint16_t >(buffer) = type_code;`
`104`	`104`
`105`	`105`	`return LEN;`
`106`	`106`	`}`