ipfixprobe - introduce process RTSP plugin

Author: Pavel Siska

src/plugins/process/CMakeLists.txt

@@ -24,3 +24,4 @@ add_subdirectory(passiveDns)
 add_subdirectory(smtp)
 add_subdirectory(quic)
 add_subdirectory(tls)
+add_subdirectory(rtsp)

src/plugins/process/rtsp/CMakeLists.txt

@@ -0,0 +1,20 @@
+project(ipfixprobe-process-rtsp VERSION 1.0.0 DESCRIPTION "ipfixprobe-process-rtsp plugin")
+
+add_library(ipfixprobe-process-rtsp MODULE
+    src/rtsp.cpp
+    src/rtsp.hpp
+)
+
+set_target_properties(ipfixprobe-process-rtsp PROPERTIES
+    CXX_VISIBILITY_PRESET hidden
+    VISIBILITY_INLINES_HIDDEN YES
+)
+
+target_include_directories(ipfixprobe-process-rtsp PRIVATE
+    ${CMAKE_SOURCE_DIR}/include/
+    ${CMAKE_SOURCE_DIR}/src/plugins/process/common
+)
+
+install(TARGETS ipfixprobe-process-rtsp
+    LIBRARY DESTINATION "${INSTALL_DIR_LIB}/ipfixprobe/process/"
+)

src/plugins/process/rtsp/README.md

@@ -1,52 +1,40 @@
 /**
- * \file rtsp.cpp
- * \brief Plugin for parsing RTSP traffic
- * \author Jiri Havranek <[email protected]>
- * \date 2020
- */
-/*
- * Copyright (C) 2020 CESNET
- *
- * LICENSE TERMS
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in
- *    the documentation and/or other materials provided with the
- *    distribution.
- * 3. Neither the name of the Company nor the names of its contributors
- *    may be used to endorse or promote products derived from this
- *    software without specific prior written permission.
- *
+ * @file
+ * @brief Plugin for parsing RTSP traffic.
+ * @author Jiri Havranek <[email protected]>
+ * @author Pavel Siska <[email protected]>
+ * @date 2025
  *
+ * Copyright (c) 2025 CESNET
  *
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
+#include "common.hpp"
+#include "rtsp.hpp"
+
 #include <cstdlib>
 #include <cstring>
 #include <iostream>
 
+#include <ipfixprobe/pluginFactory/pluginManifest.hpp>
+#include <ipfixprobe/pluginFactory/pluginRegistrar.hpp>
+
 #ifdef WITH_NEMEA
 #include <unirec/unirec.h>
 #endif
 
-#include "common.hpp"
-#include "rtsp.hpp"
-
 namespace ipxp {
 
-int RecordExtRTSP::REGISTERED_ID = -1;
+int RecordExtRTSP::REGISTERED_ID = ProcessPluginIDGenerator::instance().generatePluginID();
 
-__attribute__((constructor)) static void register_this_plugin()
-{
-	static PluginRecord rec = PluginRecord("rtsp", []() { return new RTSPPlugin(); });
-	register_plugin(&rec);
-	RecordExtRTSP::REGISTERED_ID = register_extension();
-}
+static const PluginManifest rtspPluginManifest = {
+	.name = "rtsp",
+	.description = "Rtsp process plugin for parsing rtsp traffic.",
+	.pluginVersion = "1.0.0",
+	.apiVersion = "1.0.0",
+	.usage = nullptr,
+};
 
 // #define DEBUG_RTSP
 
@@ -67,13 +55,14 @@ __attribute__((constructor)) static void register_this_plugin()
 #define RTSP_LINE_DELIMITER '\n'
 #define RTSP_KEYVAL_DELIMITER ':'
 
-RTSPPlugin::RTSPPlugin()
+RTSPPlugin::RTSPPlugin(const std::string& params)
 	: recPrealloc(nullptr)
 	, flow_flush(false)
 	, requests(0)
 	, responses(0)
 	, total(0)
 {
+	init(params.c_str());
 }
 
 RTSPPlugin::~RTSPPlugin()
@@ -506,4 +495,6 @@ void RTSPPlugin::add_ext_rtsp_response(const char* data, int payload_len, Flow&
 	}
 }
 
+static const PluginRegistrar<RTSPPlugin, ProcessPluginFactory> rtspRegistrar(rtspPluginManifest);
+
 } // namespace ipxp

src/plugins/process/rtsp.cpp src/plugins/process/rtsp/src/rtsp.cppsrc/plugins/process/rtsp.cpp renamed to src/plugins/process/rtsp/src/rtsp.cpp

@@ -1,33 +1,16 @@
 /**
- * \file rtsp.hpp
- * \brief Plugin for parsing RTSP traffic
- * \author Jiri Havranek <[email protected]>
- * \date 2020
- */
-/*
- * Copyright (C) 2020 CESNET
- *
- * LICENSE TERMS
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in
- *    the documentation and/or other materials provided with the
- *    distribution.
- * 3. Neither the name of the Company nor the names of its contributors
- *    may be used to endorse or promote products derived from this
- *    software without specific prior written permission.
- *
+ * @file
+ * @brief Plugin for parsing RTSP traffic.
+ * @author Jiri Havranek <[email protected]>
+ * @author Pavel Siska <[email protected]>
+ * @date 2025
  *
+ * Copyright (c) 2025 CESNET
  *
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
-#ifndef IPXP_PROCESS_RTSP_HPP
-#define IPXP_PROCESS_RTSP_HPP
+#pragma once
 
 #include <cstdlib>
 #include <cstring>
@@ -38,12 +21,10 @@
 #include <fields.h>
 #endif
 
-#include "http.hpp"
-
 #include <ipfixprobe/flowifc.hpp>
 #include <ipfixprobe/ipfix-elements.hpp>
 #include <ipfixprobe/packet.hpp>
-#include <ipfixprobe/process.hpp>
+#include <ipfixprobe/processPlugin.hpp>
 
 namespace ipxp {
 
@@ -188,7 +169,7 @@ struct RecordExtRTSP : public RecordExt {
  */
 class RTSPPlugin : public ProcessPlugin {
 public:
-	RTSPPlugin();
+	RTSPPlugin(const std::string& params);
 	~RTSPPlugin();
 	void init(const char* params);
 	void close();
@@ -218,4 +199,3 @@ class RTSPPlugin : public ProcessPlugin {
 };
 
 } // namespace ipxp
-#endif /* IPXP_PROCESS_RTSP_HPP */