Skip to content

Commit 630bac4

Browse files
authored
Merge pull request #311 from CESNET/telemetry-static-odr-fix
Update Telemetry to v1.3.1 and switch to header-only integration
2 parents 2167668 + 07fc8f2 commit 630bac4

File tree

6 files changed

+7
-13
lines changed

6 files changed

+7
-13
lines changed

external/telemetry.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# - telemetry::telemetry (C++ library for telemetry data collection)
66
# - telemetry::appFs (C++ library that expose telemetry data as a Fuse filesystem)
77

8-
set(TELEMETRY_BUILD_SHARED ON)
8+
set(TELEMETRY_BUILD_SHARED OFF)
99
set(TELEMETRY_INSTALL_TARGETS OFF)
1010
set(TELEMETRY_PACKAGE_BUILDER OFF)
1111
set(TELEMETRY_ENABLE_TESTS OFF)
@@ -17,7 +17,7 @@ set(GIT_REPO https://github.com/CESNET/telemetry.git)
1717
FetchContent_Declare(
1818
telemetry
1919
GIT_REPOSITORY ${GIT_REPO}
20-
GIT_TAG v1.2.0
20+
GIT_TAG v1.3.1
2121
)
2222

2323
# Make sure that subproject accepts predefined build options without warnings.

src/plugins/input/dpdk/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ target_include_directories(ipfixprobe-input-dpdk PRIVATE
2626
${DPDK_INCLUDE_DIRS}
2727
${CMAKE_SOURCE_DIR}/include/
2828
${CMAKE_SOURCE_DIR}/src/plugins/input/parser
29+
${telemetry_SOURCE_DIR}/include
2930
)
3031

3132
target_compile_options(ipfixprobe-input-dpdk PRIVATE ${DPDK_CFLAGS_OTHER})
3233
target_compile_options(ipfixprobe-input-dpdk PRIVATE -Wno-volatile -Wno-pedantic)
3334

3435
target_link_libraries(ipfixprobe-input-dpdk PRIVATE
35-
telemetry::telemetry
3636
${DPDK_LIBRARIES}
3737
)
3838

src/plugins/input/nfb/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ set_target_properties(ipfixprobe-input-nfb PROPERTIES
1818
target_include_directories(ipfixprobe-input-nfb PRIVATE
1919
${CMAKE_SOURCE_DIR}/include/
2020
${CMAKE_SOURCE_DIR}/src/plugins/input/parser
21+
${telemetry_SOURCE_DIR}/include
2122
)
2223

2324
target_link_libraries(ipfixprobe-input-nfb PRIVATE
2425
nfb::nfb
2526
numa::numa
26-
telemetry::telemetry
2727
)
2828

2929
install(TARGETS ipfixprobe-input-nfb

src/plugins/input/pcap/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ target_include_directories(ipfixprobe-input-pcap PRIVATE
1515
${PCAP_INCLUDE_DIRS}
1616
${CMAKE_SOURCE_DIR}/include/
1717
${CMAKE_SOURCE_DIR}/src/plugins/input/parser
18+
${telemetry_SOURCE_DIR}/include
1819
)
1920

2021
target_compile_definitions(ipfixprobe-input-pcap PRIVATE
@@ -23,7 +24,6 @@ target_compile_definitions(ipfixprobe-input-pcap PRIVATE
2324

2425
target_link_libraries(ipfixprobe-input-pcap PRIVATE
2526
${PCAP_LIBRARIES}
26-
telemetry::telemetry
2727
)
2828

2929
install(TARGETS ipfixprobe-input-pcap

src/plugins/input/raw/CMakeLists.txt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,7 @@ set_target_properties(ipfixprobe-input-raw PROPERTIES
1515
target_include_directories(ipfixprobe-input-raw PRIVATE
1616
${CMAKE_SOURCE_DIR}/include/
1717
${CMAKE_SOURCE_DIR}/src/plugins/input/parser
18-
)
19-
20-
target_link_libraries(ipfixprobe-input-raw PRIVATE
21-
telemetry::telemetry
18+
${telemetry_SOURCE_DIR}/include
2219
)
2320

2421
install(TARGETS ipfixprobe-input-raw

src/plugins/storage/cache/CMakeLists.txt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,7 @@ set_target_properties(ipfixprobe-storage-cache PROPERTIES
2323

2424
target_include_directories(ipfixprobe-storage-cache PRIVATE
2525
${CMAKE_SOURCE_DIR}/include/
26-
)
27-
28-
target_link_libraries(ipfixprobe-storage-cache PRIVATE
29-
telemetry::telemetry
26+
${telemetry_SOURCE_DIR}/include
3027
)
3128

3229
install(TARGETS ipfixprobe-storage-cache

0 commit comments

Comments
 (0)