stats: fixed issues reported by coverity

Author: havraji6

ipfixprobe.cpp

@@ -543,7 +543,8 @@ void serve_stat_clients(ipxp_conf_t &conf, struct pollfd pfds[2])
       int fd = accept(pfds[0].fd, NULL, NULL);
       if (pfds[1].fd == -1) {
          pfds[1].fd = fd;
-      } else {
+      } else if (fd != -1) {
+         // Close incoming connection
          close(fd);
       }
    }

ipfixprobe_stats.cpp

@@ -104,28 +104,29 @@ int main(int argc, char *argv[])
    std::string path;
    IpfixStatsParser parser;
 
+
    signal(SIGTERM, signal_handler);
    signal(SIGINT, signal_handler);
-
    try {
       parser.parse(argc - 1, const_cast<const char **>(argv) + 1);
-   } catch (ParserError &e) {
+
+      if (parser.m_help) {
+         parser.usage(std::cout, 0);
+         goto EXIT;
+      }
+
+      path = DEFAULTSOCKETDIR "/ipfixprobe_" + std::to_string(parser.m_pid) + ".sock";
+      fd = connect_to_exporter(path.c_str());
+      if (fd == -1) {
+         error("connecting to exporter");
+         goto EXIT;
+      }
+   } catch (std::runtime_error &e) {
       error(e.what());
       status = EXIT_FAILURE;
       goto EXIT;
    }
 
-   if (parser.m_help) {
-      parser.usage(std::cout, 0);
-      goto EXIT;
-   }
-
-   path = DEFAULTSOCKETDIR "/ipfixprobe_" + std::to_string(parser.m_pid) + ".sock";
-   fd = connect_to_exporter(path.c_str());
-   if (fd == -1) {
-      error("connecting to exporter");
-      goto EXIT;
-   }
    while (!stop) {
       *(uint32_t *) buffer = MSG_MAGIC;
       // Send stats data request

stats.cpp

@@ -85,7 +85,7 @@ int create_stats_sock(const char *path)
 
    unlink(addr.sun_path);
    fd = socket(AF_UNIX, SOCK_STREAM, 0);
-   if (fd) {
+   if (fd != -1) {
       if (bind(fd, (struct sockaddr *) &addr, sizeof(addr)) == -1) {
          perror("unable to bind socket");
          close(fd);