ndp input plugin - remove plugin error exception

Author: jaroslavpesek

input/ndp.cpp

@@ -62,6 +62,7 @@ telemetry::Content NdpPacketReader::get_queue_telemetry()
    telemetry::Dict dict;
    dict["received_packets"] = m_stats.receivedPackets;
    dict["received_bytes"] = m_stats.receivedBytes;
+   dict["bad_metadata"] = m_stats.bad_metadata;
    return dict;
 }
 
@@ -110,10 +111,10 @@ void NdpPacketReader::init_ifc(const std::string &dev)
    }
 }
 
-void NdpPacketReader::parse_ctt_metadata(const ndp_packet *ndp_packet, Metadata_CTT &ctt)
+int NdpPacketReader::parse_ctt_metadata(const ndp_packet *ndp_packet, Metadata_CTT &ctt)
 {
    if (ndp_packet->header_length != 32) {
-      throw PluginError("Metadata bad length, cannot parse, length: " + std::to_string(ndp_packet->header_length));
+      return -1;
    }
    const uint8_t *metadata = ndp_packet->header;
 
@@ -139,7 +140,7 @@ void NdpPacketReader::parse_ctt_metadata(const ndp_packet *ndp_packet, Metadata_
    ctt.l3_ptype        = static_cast<L3PType>(extract(metadata, 220, 4));
    ctt.l4_ptype        = static_cast<L4PType>(extract(metadata, 224, 4));
 
-   return;
+   return 0;
 }
 
 InputPlugin::Result NdpPacketReader::get(PacketBlock &packets)
@@ -165,8 +166,13 @@ InputPlugin::Result NdpPacketReader::get(PacketBlock &packets)
       read_pkts++;
       if (m_ctt_metadata) {
          Metadata_CTT ctt;
-         parse_ctt_metadata(ndp_packet, ctt);
-         parse_packet_ctt_metadata(&opt, m_parser_stats, ctt, ndp_packet->data, ndp_packet->data_length, ndp_packet->data_length);
+         int ret = parse_ctt_metadata(ndp_packet, ctt);
+         if (ret == -1) {
+            m_stats.bad_metadata++;
+            parse_packet(&opt, m_parser_stats, timestamp, ndp_packet->data, ndp_packet->data_length, ndp_packet->data_length);
+         } else {
+            parse_packet_ctt_metadata(&opt, m_parser_stats, ctt, ndp_packet->data, ndp_packet->data_length, ndp_packet->data_length);
+         }
       } else {
          parse_packet(&opt, m_parser_stats, timestamp, ndp_packet->data, ndp_packet->data_length, ndp_packet->data_length);
       }

input/ndp.hpp

@@ -78,6 +78,7 @@ class NdpPacketReader : public InputPlugin
    struct RxStats {
         uint64_t receivedPackets;
         uint64_t receivedBytes;
+        uint64_t bad_metadata;
    };
 
    telemetry::Content get_queue_telemetry();
@@ -88,7 +89,7 @@ class NdpPacketReader : public InputPlugin
    bool m_ctt_metadata = false;
 
    void init_ifc(const std::string &dev);
-   void parse_ctt_metadata(const ndp_packet *ndp_packet, Metadata_CTT &ctt);
+   int parse_ctt_metadata(const ndp_packet *ndp_packet, Metadata_CTT &ctt);
 };
 
 }