ipfixprobe - introduce process NTP plugin

Author: Pavel Siska

src/plugins/process/CMakeLists.txt

@@ -26,4 +26,5 @@ if (ENABLE_PROCESS_EXPERIMENTAL)
 	add_subdirectory(sip)
 	add_subdirectory(rtsp)
 	add_subdirectory(mpls)
+	add_subdirectory(ntp)
 endif()

src/plugins/process/ntp/CMakeLists.txt

@@ -0,0 +1,20 @@
+project(ipfixprobe-process-ntp VERSION 1.0.0 DESCRIPTION "ipfixprobe-process-ntp plugin")
+
+add_library(ipfixprobe-process-ntp MODULE
+    src/ntp.cpp
+    src/ntp.hpp
+)
+
+set_target_properties(ipfixprobe-process-ntp PROPERTIES
+    CXX_VISIBILITY_PRESET hidden
+    VISIBILITY_INLINES_HIDDEN YES
+)
+
+target_include_directories(ipfixprobe-process-ntp PRIVATE
+	${CMAKE_SOURCE_DIR}/include/
+)
+
+install(
+    TARGETS ipfixprobe-process-ntp
+    LIBRARY DESTINATION "${INSTALL_DIR_LIB}/ipfixprobe/process/"
+)

src/plugins/process/ntp/README.md

@@ -1,53 +1,40 @@
 /**
- * \file ntp.cpp
- * \author Alejandro Robledo <[email protected]>
- * \date 2016
- */
-/*
- * Copyright (C) 2016 CESNET
- *
- * LICENSE TERMS
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in
- *    the documentation and/or other materials provided with the
- *    distribution.
- * 3. Neither the name of the Company nor the names of its contributors
- *    may be used to endorse or promote products derived from this
- *    software without specific prior written permission.
- *
+ * @file
+ * @brief Plugin for parsing ntp traffic.
+ * @author Alejandro Robledo <[email protected]>
+ * @date 2025
  *
+ * Copyright (c) 2025 CESNET
  *
+ * SPDX-License-Identifier: BSD-3-Clause
  */
+
+#include "ntp.hpp"
+
 #include <cstdlib>
 #include <cstring>
 #include <iomanip>
 #include <iostream>
 #include <sstream>
 
-#include <stdlib.h>
-
 #ifdef WITH_NEMEA
 #include <unirec/unirec.h>
 #endif
 
-#include "ntp.hpp"
+#include <ipfixprobe/pluginFactory/pluginManifest.hpp>
+#include <ipfixprobe/pluginFactory/pluginRegistrar.hpp>
 
 namespace ipxp {
 
-int RecordExtNTP::REGISTERED_ID = -1;
+int RecordExtNTP::REGISTERED_ID = ProcessPluginIDGenerator::instance().generatePluginID();
 
-__attribute__((constructor)) static void register_this_plugin()
-{
-	static PluginRecord rec = PluginRecord("ntp", []() { return new NTPPlugin(); });
-	register_plugin(&rec);
-	RecordExtNTP::REGISTERED_ID = register_extension();
-}
+static const PluginManifest ntpPluginManifest = {
+	.name = "ntp",
+	.description = "Ntp process plugin for parsing ntp traffic.",
+	.pluginVersion = "1.0.0",
+	.apiVersion = "1.0.0",
+	.usage = nullptr,
+};
 
 // #define DEBUG_NTP
 
@@ -58,19 +45,23 @@ __attribute__((constructor)) static void register_this_plugin()
 #define DEBUG_MSG(format, ...)
 #endif
 
-NTPPlugin::NTPPlugin()
+NTPPlugin::NTPPlugin(const std::string& params)
 	: requests(0)
 	, responses(0)
 	, total(0)
 {
+	(void) params;
 }
 
 NTPPlugin::~NTPPlugin()
 {
 	close();
 }
 
-void NTPPlugin::init(const char* params) {}
+void NTPPlugin::init(const char* params)
+{
+	(void) params;
+}
 
 void NTPPlugin::close() {}
 
@@ -448,4 +439,6 @@ NTPPlugin::parse_timestamp(const Packet& pkt, uint16_t p1, uint16_t p4, uint16_t
 	return result2;
 }
 
+static const PluginRegistrar<NTPPlugin, ProcessPluginFactory> ntpRegistrar(ntpPluginManifest);
+
 } // namespace ipxp

src/plugins/process/ntp.cpp src/plugins/process/ntp/src/ntp.cppsrc/plugins/process/ntp.cpp renamed to src/plugins/process/ntp/src/ntp.cpp

@@ -1,32 +1,15 @@
 /**
- * \file ntp.hpp
- * \author Alejandro Robledo <[email protected]>
- * \date 2016
- */
-/*
- * Copyright (C) 2016 CESNET
- *
- * LICENSE TERMS
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in
- *    the documentation and/or other materials provided with the
- *    distribution.
- * 3. Neither the name of the Company nor the names of its contributors
- *    may be used to endorse or promote products derived from this
- *    software without specific prior written permission.
- *
+ * @file
+ * @brief Plugin for parsing ntp traffic.
+ * @author Alejandro Robledo <[email protected]>
+ * @date 2025
  *
+ * Copyright (c) 2025 CESNET
  *
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
-#ifndef IPXP_PROCESS_NTP_HPP
-#define IPXP_PROCESS_NTP_HPP
+#pragma once
 
 #include <cstdlib>
 #include <cstring>
@@ -40,7 +23,7 @@
 #include <ipfixprobe/flowifc.hpp>
 #include <ipfixprobe/ipfix-elements.hpp>
 #include <ipfixprobe/packet.hpp>
-#include <ipfixprobe/process.hpp>
+#include <ipfixprobe/processPlugin.hpp>
 #include <stdio.h>
 
 namespace ipxp {
@@ -225,7 +208,7 @@ struct RecordExtNTP : public RecordExt {
  */
 class NTPPlugin : public ProcessPlugin {
 public:
-	NTPPlugin();
+	NTPPlugin(const std::string& params);
 	~NTPPlugin();
 	void init(const char* params);
 	void close();
@@ -249,4 +232,3 @@ class NTPPlugin : public ProcessPlugin {
 };
 
 } // namespace ipxp
-#endif /* IPXP_PROCESS_NTP_HPP */