ipfixprobe - introduce process DNSSD plugin

Author: Pavel Siska

src/plugins/process/CMakeLists.txt

@@ -17,3 +17,4 @@ add_subdirectory(ssdp)
 add_subdirectory(ssaDetector)
 add_subdirectory(mqtt)
 add_subdirectory(dns)
+add_subdirectory(dnssd)

src/plugins/process/dnssd/CMakeLists.txt

@@ -0,0 +1,20 @@
+project(ipfixprobe-process-dnssd VERSION 1.0.0 DESCRIPTION "ipfixprobe-process-dnssd plugin")
+
+add_library(ipfixprobe-process-dnssd MODULE
+    src/dnssd.cpp
+    src/dnssd.hpp
+)
+
+set_target_properties(ipfixprobe-process-dnssd PROPERTIES
+    CXX_VISIBILITY_PRESET hidden
+    VISIBILITY_INLINES_HIDDEN YES
+)
+
+target_include_directories(ipfixprobe-process-dnssd PRIVATE 
+    ${CMAKE_SOURCE_DIR}/include/
+    ${CMAKE_SOURCE_DIR}/src/plugins/process/common
+)
+
+install(TARGETS ipfixprobe-process-dnssd
+    LIBRARY DESTINATION "${INSTALL_DIR_LIB}/ipfixprobe/process/"
+)

src/plugins/process/dnssd/README.md

@@ -1,57 +1,46 @@
 /**
- * \file dnssd.cpp
- * \brief Plugin for parsing DNS-SD traffic.
- * \author Ondrej Sedlacek [email protected]
- * \author Jiri Havranek <[email protected]>
- * \date 2020
- */
-/*
- * Copyright (C) 2020 CESNET
- *
- * LICENSE TERMS
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in
- *    the documentation and/or other materials provided with the
- *    distribution.
- * 3. Neither the name of the Company nor the names of its contributors
- *    may be used to endorse or promote products derived from this
- *    software without specific prior written permission.
- *
+ * @file
+ * @brief Plugin for parsing dnssd traffic.
+ * @author Ondrej Sedlacek [email protected]
+ * @author Pavel Siska <[email protected]>
+ * @date 2025
  *
+ * Copyright (c) 2025 CESNET
  *
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
+#include "dnssd.hpp"
+
 #include <iostream>
 #include <sstream>
 
 #include <arpa/inet.h>
+#include <errno.h>
+#include <ipfixprobe/pluginFactory/pluginManifest.hpp>
+#include <ipfixprobe/pluginFactory/pluginRegistrar.hpp>
 #include <stdio.h>
 #include <stdlib.h>
 
 #ifdef WITH_NEMEA
 #include <unirec/unirec.h>
 #endif
 
-#include "dnssd.hpp"
-
-#include <errno.h>
-
 namespace ipxp {
 
-int RecordExtDNSSD::REGISTERED_ID = -1;
+int RecordExtDNSSD::REGISTERED_ID = ProcessPluginIDGenerator::instance().generatePluginID();
 
-__attribute__((constructor)) static void register_this_plugin()
-{
-	static PluginRecord rec = PluginRecord("dnssd", []() { return new DNSSDPlugin(); });
-	register_plugin(&rec);
-	RecordExtDNSSD::REGISTERED_ID = register_extension();
-}
+static const PluginManifest dnssdPluginManifest = {
+	.name = "dnssd",
+	.description = "Dnssd process plugin for parsing dnssd traffic.",
+	.pluginVersion = "1.0.0",
+	.apiVersion = "1.0.0",
+	.usage =
+		[]() {
+			DNSSDOptParser parser;
+			parser.usage(std::cout);
+		},
+};
 
 // #define DEBUG_DNSSD
 
@@ -81,14 +70,15 @@ __attribute__((constructor)) static void register_this_plugin()
  */
 #define GET_OFFSET(half1, half2) ((((uint8_t) (half1) & 0x3F) << 8) | (uint8_t) (half2))
 
-DNSSDPlugin::DNSSDPlugin()
+DNSSDPlugin::DNSSDPlugin(const std::string& params)
 	: txt_all_records(false)
 	, queries(0)
 	, responses(0)
 	, total(0)
 	, data_begin(nullptr)
 	, data_len(0)
 {
+	init(params.c_str());
 }
 
 DNSSDPlugin::~DNSSDPlugin()
@@ -734,4 +724,6 @@ int DNSSDPlugin::add_ext_dnssd(const char* data, unsigned int payload_len, bool
 	return 0;
 }
 
+static const PluginRegistrar<DNSSDPlugin, ProcessPluginFactory> dnssdRegistrar(dnssdPluginManifest);
+
 } // namespace ipxp

src/plugins/process/dnssd.cpp src/plugins/process/dnssd/src/dnssd.cppsrc/plugins/process/dnssd.cpp renamed to src/plugins/process/dnssd/src/dnssd.cpp

@@ -1,33 +1,16 @@
 /**
- * \file dnssd.hpp
- * \brief Plugin for parsing dnssd traffic.
- * \author Ondrej Sedlacek [email protected]
- * \date 2020
- */
-/*
- * Copyright (C) 2020 CESNET
- *
- * LICENSE TERMS
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in
- *    the documentation and/or other materials provided with the
- *    distribution.
- * 3. Neither the name of the Company nor the names of its contributors
- *    may be used to endorse or promote products derived from this
- *    software without specific prior written permission.
- *
+ * @file
+ * @brief Plugin for parsing dnssd traffic.
+ * @author Ondrej Sedlacek [email protected]
+ * @author Pavel Siska <[email protected]>
+ * @date 2025
  *
+ * Copyright (c) 2025 CESNET
  *
+ * SPDX-License-Identifier: BSD-3-Clause
  */
 
-#ifndef IPXP_PROCESS_DNSSD_HPP
-#define IPXP_PROCESS_DNSSD_HPP
+#pragma once
 
 #include <algorithm>
 #include <cstring>
@@ -40,13 +23,12 @@
 #include "fields.h"
 #endif
 
-#include "dns-utils.hpp"
-
+#include <dns-utils.hpp>
 #include <ipfixprobe/flowifc.hpp>
 #include <ipfixprobe/ipfix-elements.hpp>
 #include <ipfixprobe/options.hpp>
 #include <ipfixprobe/packet.hpp>
-#include <ipfixprobe/process.hpp>
+#include <ipfixprobe/processPlugin.hpp>
 
 namespace ipxp {
 
@@ -260,7 +242,7 @@ struct RecordExtDNSSD : public RecordExt {
  */
 class DNSSDPlugin : public ProcessPlugin {
 public:
-	DNSSDPlugin();
+	DNSSDPlugin(const std::string& params);
 	~DNSSDPlugin();
 	void init(const char* params);
 	void close();
@@ -308,4 +290,3 @@ class DNSSDPlugin : public ProcessPlugin {
 };
 
 } // namespace ipxp
-#endif /* IPXP_PROCESS_DNSSD_HPP */