server config UPDATE allow unsupported keys

Do not fail when an unsupported key format is encountered. Instead
just possibly fail if it were to be used. Fixes #563

Author: Roytak

src/server_config.c

@@ -745,8 +745,10 @@ config_pubkey_format(const struct lyd_node *node, enum nc_operation parent_op, s
         } else if (!strcmp(format, "subject-public-key-info-format")) {
             pubkey->type = NC_PUBKEY_FORMAT_X509;
         } else {
-            ERR(NULL, "Unknown public key format \"%s\".", format);
-            return 1;
+            /* do not fail, the key may still be usable, or it may have come from a keystore/truststore
+             * and have a different purpose other than NETCONF */
+            WRN(NULL, "Public key format \"%s\" not supported. The key may not be usable.", format);
+            pubkey->type = NC_PUBKEY_FORMAT_UNKNOWN;
         }
     }
 
@@ -795,8 +797,10 @@ config_privkey_format(const struct lyd_node *node, enum nc_operation parent_op,
         } else if (!strcmp(format, "openssh-private-key-format")) {
             privkey->type = NC_PRIVKEY_FORMAT_OPENSSH;
         } else {
-            ERR(NULL, "Unknown private key format \"%s\".", format);
-            return 1;
+            /* do not fail, the key may still be usable, or it may have come from a keystore/truststore
+             * and have a different purpose other than NETCONF */
+            WRN(NULL, "Private key format \"%s\" not supported. The key may not be usable.", format);
+            privkey->type = NC_PRIVKEY_FORMAT_UNKNOWN;
         }
     }
 

tests/test_config.c

@@ -786,6 +786,8 @@ test_config_all_nodes(void **state)
     ret = nc_server_config_setup_diff(dup);
     assert_int_equal(ret, 0);
 
+    free(mem);
+    free(mem_filled);
     lyd_free_all(dup);
     lyd_free_all(tree);
 }
@@ -968,6 +970,7 @@ main(void)
         cmocka_unit_test_setup_teardown(test_preserve_conn, setup_f, ln2_glob_test_teardown),
         cmocka_unit_test_setup_teardown(test_transport_params_oper_get, setup_f, ln2_glob_test_teardown),
         cmocka_unit_test_setup_teardown(test_config_all_nodes, setup_f, ln2_glob_test_teardown),
+        cmocka_unit_test_setup_teardown(test_unusupported_asymkey_format, setup_f, ln2_glob_test_teardown),
     };
 
     /* try to get ports from the environment, otherwise use the default */