session server BUGFIX fix bugs found by coverity

Author: Roytak

src/server_config.c

@@ -5438,12 +5438,25 @@ nc_server_config_tls_dup(const struct nc_server_tls_opts *src, struct nc_server_
         dst_ctn->id = src_ctn->id;
         if (src_ctn->fingerprint) {
             dst_ctn->fingerprint = strdup(src_ctn->fingerprint);
-            NC_CHECK_ERRMEM_GOTO(!dst_ctn->fingerprint, rc = 1, cleanup);
+            if (!dst_ctn->fingerprint) {
+                /* we need to free the dst_ctn we just allocated */
+                free(dst_ctn);
+                rc = 1;
+                ERRMEM;
+                goto cleanup;
+            }
         }
         dst_ctn->map_type = src_ctn->map_type;
         if (src_ctn->name) {
             dst_ctn->name = strdup(src_ctn->name);
-            NC_CHECK_ERRMEM_GOTO(!dst_ctn->name, rc = 1, cleanup);
+            if (!dst_ctn->name) {
+                /* we need to free the dst_ctn we just allocated */
+                free(dst_ctn->fingerprint);
+                free(dst_ctn);
+                rc = 1;
+                ERRMEM;
+                goto cleanup;
+            }
         }
 
         if (prev_ctn) {

src/session_server.c

@@ -4171,9 +4171,7 @@ nc_server_notif_cert_exp_thread(void *arg)
     if (targ->clb_free_data) {
         targ->clb_free_data(targ->clb_data);
     }
-    if (exp_dates) {
-        nc_server_notif_cert_exp_data_destroy(exp_dates, exp_date_count, intervals);
-    }
+    nc_server_notif_cert_exp_data_destroy(exp_dates, exp_date_count, intervals);
     free(targ);
     return NULL;
 }

src/session_server_tls.c

@@ -522,7 +522,7 @@ _nc_server_tls_verify_peer_cert(void *peer_cert, struct nc_server_tls_client_aut
     int ret;
     void *cert;
     struct nc_certificate *certs;
-    uint32_t i, cert_count;
+    uint32_t i, cert_count = 0;
 
     if (client_auth->ee_certs_store == NC_STORE_LOCAL) {
         /* local definition */

tests/test_config.c

@@ -645,19 +645,22 @@ read_config_file(const char *path, char **mem)
 {
     FILE *f;
     long fsize;
+    size_t read;
 
     f = fopen(path, "r");
     assert_non_null(f);
 
     fseek(f, 0, SEEK_END);
     fsize = ftell(f);
+    assert_true(fsize > 0);
     fseek(f, 0, SEEK_SET);
 
     *mem = malloc(fsize + 1);
     assert_non_null(*mem);
 
-    fread(*mem, 1, fsize, f);
-    (*mem)[fsize] = '\0';
+    read = fread(*mem, 1, fsize, f);
+    assert_int_equal(read, fsize);
+    (*mem)[read] = '\0';
 
     fclose(f);
 }